Skip to content

RUM-14581: Redirect TraceStructureWriter default output from stderr to stdout#3191

Merged
hamorillo merged 1 commit into
developfrom
hector.morilloprieto/RUM-14581
Feb 20, 2026
Merged

RUM-14581: Redirect TraceStructureWriter default output from stderr to stdout#3191
hamorillo merged 1 commit into
developfrom
hector.morilloprieto/RUM-14581

Conversation

@hamorillo

@hamorillo hamorillo commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Changes the default output stream in TraceStructureWriter from System.err to System.out, and updates the close() guard accordingly. This eliminates noisy STANDARD_ERROR output during test runs.

You can see the difference between this report (before this PR) and the PR one.

Motivation

After #3163 enabled TestLogEvent.STANDARD_ERROR in the JUnit configuration, pre-existing System.err usage in TraceStructureWriter became visible as noisy output during test runs. The trace structure output is informational/debug data, not error output, so it belongs on stdout.

Additional Notes

  • TraceStructureWriter is only instantiated by ListWriter (a test-only writer), so this has no production impact.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

…o stdout

The default stream (used when no file is specified) was System.err, causing
trace structure debug output to flood STANDARD_ERROR during test runs.
This is informational data, not error output. The close() guard is updated
accordingly to avoid closing System.out.
@hamorillo
hamorillo force-pushed the hector.morilloprieto/RUM-14581 branch from 7fc0108 to 1a1ea16 Compare February 20, 2026 08:32
@datadog-official

This comment has been minimized.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.32%. Comparing base (da85551) to head (1a1ea16).

Files with missing lines Patch % Lines
...adog/trace/common/writer/TraceStructureWriter.java 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3191      +/-   ##
===========================================
+ Coverage    71.31%   71.32%   +0.01%     
===========================================
  Files          929      929              
  Lines        34442    34442              
  Branches      5813     5813              
===========================================
+ Hits         24562    24564       +2     
+ Misses        8247     8245       -2     
  Partials      1633     1633              
Files with missing lines Coverage Δ
...adog/trace/common/writer/TraceStructureWriter.java 47.83% <0.00%> (ø)

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hamorillo
hamorillo marked this pull request as ready for review February 20, 2026 09:50
@hamorillo
hamorillo requested a review from a team as a code owner February 20, 2026 09:50
@hamorillo
hamorillo merged commit 699dce4 into develop Feb 20, 2026
26 checks passed
@hamorillo
hamorillo deleted the hector.morilloprieto/RUM-14581 branch February 20, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants