Fix evaluations feature startup deadlock#3186
Merged
Merged
Conversation
0xnm
force-pushed
the
nogorodnikov/fix-evaluations-startup-deadlock
branch
from
February 18, 2026 09:18
fc58dc7 to
2fc5438
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3186 +/- ##
========================================
Coverage 71.26% 71.26%
========================================
Files 929 929
Lines 34447 34442 -5
Branches 5816 5813 -3
========================================
- Hits 24546 24543 -3
- Misses 8252 8256 +4
+ Partials 1649 1643 -6
🚀 New features to boost your workflow:
|
kikoveiga
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The following code causes a deadlock (we are reading context while it is updated) preventing sample app to start
dd-sdk-android/features/dd-sdk-android-flags/src/main/kotlin/com/datadog/android/flags/internal/EvaluationsFeature.kt
Lines 118 to 119 in b79d675
This PR fixes it by moving core context read to the event write stage.
Review checklist (to be filled by reviewers)