Add detekt-cli jar to .gitignore#3185
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3185 +/- ##
===========================================
- Coverage 71.28% 71.27% -0.01%
===========================================
Files 929 929
Lines 34447 34442 -5
Branches 5816 5815 -1
===========================================
- Hits 24553 24546 -7
- Misses 8258 8263 +5
+ Partials 1636 1633 -3 🚀 New features to boost your workflow:
|
hamorillo
marked this pull request as ready for review
February 17, 2026 20:05
The customDetektRules Gradle task requires detekt-cli-*-all.jar in the root folder, but this binary should not be committed to the repository. Adding a wildcard pattern ensures all current and future versions are ignored.
hamorillo
force-pushed
the
hector.morilloprieto/addDetektCLItoGitIgnore
branch
from
February 18, 2026 06:56
ff38325 to
6c918df
Compare
0xnm
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a wildcard pattern (
detekt-cli-*-all.jar) to.gitignoreso that the detekt CLI jar required by thecustomDetektRulesGradle task is not committed to the repository.Motivation
The
customDetektRulestask needsdetekt-cli-*-all.jarin the root folder to run, but this is a large binary that should not be tracked in version control. Previously it was not ignored, risking accidental commits.Additional Notes
The pattern uses a wildcard to cover all versions (e.g.,
detekt-cli-1.23.4-all.jar,detekt-cli-2.0.0-all.jar, etc.).Review checklist (to be filled by reviewers)