Skip to content

Fix JSON model generation task caching#3179

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/fix-json-generation-task-caching
Feb 16, 2026
Merged

Fix JSON model generation task caching#3179
0xnm merged 1 commit into
developfrom
nogorodnikov/fix-json-generation-task-caching

Conversation

@0xnm

@0xnm 0xnm commented Feb 16, 2026

Copy link
Copy Markdown
Member

What does this PR do?

JSON model can reference external file, outside of the inputDirPath property, leading to build caching missing changes in such files.

This PR adds extra property to add external folder to watch.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@marco-saia-datadog

Copy link
Copy Markdown
Member

Nice! Thanks for addressing this quickly 👍

@datadog-datadog-prod-us1

This comment has been minimized.

@codecov-commenter

codecov-commenter commented Feb 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.39%. Comparing base (369ea6c) to head (8987c87).
⚠️ Report is 372 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3179      +/-   ##
===========================================
+ Coverage    71.20%   71.39%   +0.19%     
===========================================
  Files          922      922              
  Lines        34099    34175      +76     
  Branches      5776     5776              
===========================================
+ Hits         24277    24396     +119     
+ Misses        8190     8174      -16     
+ Partials      1632     1605      -27     

see 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm marked this pull request as ready for review February 16, 2026 10:45
@0xnm
0xnm requested a review from a team as a code owner February 16, 2026 10:45
@0xnm
0xnm merged commit 1f0c410 into develop Feb 16, 2026
27 checks passed
@0xnm
0xnm deleted the nogorodnikov/fix-json-generation-task-caching branch February 16, 2026 15:29
@ncreated
ncreated restored the nogorodnikov/fix-json-generation-task-caching branch April 9, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants