RUMS-5535: Fix global attributes not copied when view stops#3177
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3177 +/- ##
===========================================
+ Coverage 71.20% 71.23% +0.03%
===========================================
Files 922 922
Lines 34099 34100 +1
Branches 5776 5776
===========================================
+ Hits 24277 24289 +12
+ Misses 8190 8175 -15
- Partials 1632 1636 +4
🚀 New features to boost your workflow:
|
ambushwork
force-pushed
the
yl/fix-global-attributes-missing-in-view
branch
from
February 13, 2026 12:16
fc57f4e to
6acd907
Compare
ambushwork
changed the title
ambushwork
marked this pull request as ready for review
February 13, 2026 12:20
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
kikoveiga
previously approved these changes
Feb 13, 2026
0xnm
reviewed
Feb 16, 2026
aleksandr-gringauz
previously approved these changes
Feb 16, 2026
ambushwork
dismissed stale reviews from aleksandr-gringauz and kikoveiga
via
February 17, 2026 09:48
c14d6ec
ambushwork
force-pushed
the
yl/fix-global-attributes-missing-in-view
branch
from
February 17, 2026 09:48
6acd907 to
c14d6ec
Compare
0xnm
approved these changes
Feb 17, 2026
aleksandr-gringauz
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Issue
When customers call
GlobalRumMonitor.get().addAttribute(attribute.key, attribute.value), they expect to see the custom attributes in all the following views, actions, resources and errors. There is an issue reported by a customer that the global attributes are missing in most of the views in the sessions, while they are available in all the actions, resources or errors.Cause
When a view is stopped, it is expected to copy the snapshot of custom attributes of the parent scope at the moment it stops, which is the case when customer calls stop view manually, but not the case if stop view is triggered by
StartViewof the new view. Thus, whensendViewUpdateis triggered by stopView like this, it is updated without the global attributes.Fix
apply the same snapshot copy logic into stop view when it's triggered by a new start view.
Review checklist (to be filled by reviewers)