Skip to content

[Flags] Evaluations subfeature#3159

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 16 commits into
feature/flags-evaluations-loggingfrom
typo/flags-evaluations-subfeature
Jan 29, 2026
Merged

[Flags] Evaluations subfeature#3159
gh-worker-dd-mergequeue-cf854d[bot] merged 16 commits into
feature/flags-evaluations-loggingfrom
typo/flags-evaluations-subfeature

Conversation

@typotter

@typotter typotter commented Jan 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📚 Evaluation Logging Stacked Pull Requests 📚

🔲 Integration & Configuration (PR #3147)
🔲 Storage & Network Infrastructure (PR #3146)
🔲 Aggregation Engine & Test Utilities (PR #3145)
🔲 Event Schema & Data Models (PR #3144)
👉 Evaluations Subfeature (PR #3159)
⎿ typo/FFL-1720-android-kotlin-sdk-emits (feature branch)

Datadog Internal
🎟️ Ticket: FFL-1720 - Implement Evaluation Logging for Android SDK

What does this PR do?

Creates the EvaluationsFeature as a dedicated subfeature to manage the lifecycle of the evaluations aggregation engine, event writer and network request factory. This allows the Flags feature to have 2 separate store-and-upload mechanisms (one for Exposures and one for Evaluations).

Motivation

We need to implement Evaluation Logging to provide comprehensive visibility into all feature flag evaluations.

StorageBackedFeatures such as the FlagsFeature make use of built-in SDK core mechanisms to store events locally for persistence and the upload to an intake endpoint in batches (as well as retries etc.). Only one event type can be managed by a StorageBackedFeature so we need to create a place for Evaluations.

Description

This PR adds the EvaluationsFeature: a dedicated subfeature that owns evaluation logging

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@typotter
typotter changed the base branch from develop to feature/flags-evaluations-logging January 27, 2026 17:54
This was referenced Jan 27, 2026
Merged
Merged
Merged
Merged
@typotter
typotter marked this pull request as ready for review January 28, 2026 06:24
@typotter
typotter requested a review from a team as a code owner January 28, 2026 06:24
@datadog-datadog-prod-us1

This comment has been minimized.

Sign in to view
0xnm
0xnm reviewed Jan 28, 2026
View reviewed changes
Comment thread build.gradle.kts Outdated
Comment thread features/dd-sdk-android-flags/api/apiSurface Outdated
Comment thread ...d-sdk-android-flags/src/main/kotlin/com/datadog/android/flags/internal/EvaluationsFeature.kt Outdated
Comment thread ...ures/dd-sdk-android-flags/src/main/kotlin/com/datadog/android/flags/internal/FlagsFeature.kt Outdated
Comment thread ...ures/dd-sdk-android-flags/src/main/kotlin/com/datadog/android/flags/internal/FlagsFeature.kt Outdated
typotter
typotter commented Jan 28, 2026
View reviewed changes

@typotter typotter left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nikita!

Comment thread build.gradle.kts Outdated
Comment thread features/dd-sdk-android-flags/api/apiSurface Outdated
Comment thread ...d-sdk-android-flags/src/main/kotlin/com/datadog/android/flags/internal/EvaluationsFeature.kt Outdated
Comment thread ...ures/dd-sdk-android-flags/src/main/kotlin/com/datadog/android/flags/internal/FlagsFeature.kt Outdated
Comment thread ...ures/dd-sdk-android-flags/src/main/kotlin/com/datadog/android/flags/internal/FlagsFeature.kt Outdated
0xnm
0xnm previously approved these changes Jan 28, 2026
View reviewed changes
@typotter

typotter commented Jan 28, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jan 28, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-01-28 16:24:56 UTC ℹ️ Start processing command /merge

2026-01-28 16:26:41 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-01-28 20:26:34 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@typotter
typotter requested a review from 0xnm January 28, 2026 16:31
@typotter

typotter commented Jan 28, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @0xnm I had to refresh the api files. PTAL

0xnm
0xnm reviewed Jan 28, 2026
View reviewed changes
Comment thread features/dd-sdk-android-flags/api/apiSurface Outdated
@typotter
typotter requested a review from 0xnm January 28, 2026 16:58
@typotter

typotter commented Jan 29, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jan 29, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-01-29 03:51:59 UTC ℹ️ Start processing command /merge

2026-01-29 03:52:04 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in feature/flags-evaluations-logging is approximately 0s (p90).

2026-01-29 04:46:55 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 94e4249 into feature/flags-evaluations-logging Jan 29, 2026
27 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the typo/flags-evaluations-subfeature branch January 29, 2026 04:46
@typotter typotter mentioned this pull request Jan 30, 2026
Merged
3 tasks
This was referenced Feb 17, 2026
Closed
Merged
@ncreated
ncreated restored the typo/flags-evaluations-subfeature branch April 9, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
@aleksandr-gringauz aleksandr-gringauz Awaiting requested review from aleksandr-gringauz

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@typotter @0xnm @aleksandr-gringauz