Add Experimental annotation on Profiling APIs & Bug fix#3143
Merged
Conversation
ambushwork
force-pushed
the
yl/profiling-add-experimental-api
branch
from
January 22, 2026 08:51
c576f53 to
4f7b4b6
Compare
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
🎯 Code Coverage 🔗 Commit SHA: 85e32a3 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
ambushwork
marked this pull request as ready for review
January 22, 2026 09:17
0xnm
reviewed
Jan 22, 2026
ambushwork
force-pushed
the
yl/profiling-add-experimental-api
branch
from
January 22, 2026 09:29
4f7b4b6 to
c6a2eba
Compare
ambushwork
force-pushed
the
yl/profiling-add-experimental-api
branch
from
January 22, 2026 10:15
c6a2eba to
85e32a3
Compare
0xnm
approved these changes
Jan 22, 2026
| * Copyright 2016-Present Datadog, Inc. | ||
| */ | ||
|
|
||
| @file:OptIn(ExperimentalProfilingApi::class) |
Member
There was a problem hiding this comment.
probably should be at the class level? alternatively we can opt in for the whole module https://kotlinlang.org/docs/opt-in-requirements.html#opt-in-a-module
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3143 +/- ##
===========================================
- Coverage 70.95% 70.94% -0.01%
===========================================
Files 912 912
Lines 33519 33520 +1
Branches 5636 5636
===========================================
- Hits 23783 23779 -4
- Misses 8159 8169 +10
+ Partials 1577 1572 -5
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
runningInstancescollection is not cleaned, leadingisRunningreturn true even if the profiler has stopped.Review checklist (to be filled by reviewers)