Skip to content

[Flags] fix: add STATIC resolution reason#3131

Merged
dd-mergequeue[bot] merged 2 commits into
feature/flags-ofeatfrom
typo/add-static-resolution-reason-ofeat
Jan 19, 2026
Merged

[Flags] fix: add STATIC resolution reason#3131
dd-mergequeue[bot] merged 2 commits into
feature/flags-ofeatfrom
typo/add-static-resolution-reason-ofeat

Conversation

@typotter

@typotter typotter commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR adds the STATIC resolution reason to the flags and flags-openfeature modules

Motivation

This resolution reason is returned from the flagging service when a flag's value is determined by the platform default rather than any targeting rules

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@typotter
typotter marked this pull request as ready for review January 16, 2026 22:43
@typotter
typotter requested a review from a team as a code owner January 16, 2026 22:43
@datadog-official

datadog-official Bot commented Jan 16, 2026 •
edited
Loading

Copy link
Copy Markdown

🎯 Code Coverage
• Patch Coverage: 100.00%
• Overall Coverage: 100.00% (+34.11%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 96b1913 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter

codecov-commenter commented Jan 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.00%. Comparing base (a45cc1a) to head (96b1913).
⚠️ Report is 16 commits behind head on feature/flags-ofeat.

Additional details and impacted files 
@@                   Coverage Diff                   @@
##           feature/flags-ofeat    #3131      +/-   ##
=======================================================
+ Coverage                70.81%   71.00%   +0.19%     
=======================================================
  Files                      899      899              
  Lines                    33137    33145       +8     
  Branches                  5592     5594       +2     
=======================================================
+ Hits                     23465    23534      +69     
+ Misses                    8108     8068      -40     
+ Partials                  1564     1543      -21
Files with missing lines Coverage Δ
...om/datadog/android/flags/model/ResolutionReason.kt 100.00% <100.00%> (ø)

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

leoromanovsky
leoromanovsky approved these changes Jan 17, 2026
View reviewed changes
Comment thread ...res/dd-sdk-android-flags/src/main/kotlin/com/datadog/android/flags/model/ResolutionReason.kt
enum class ResolutionReason {
/**
* The resolved value is the default value for the flag.
* No targeting rules matched; the fallthrough/default allocation was used.

@leoromanovsky leoromanovsky Jan 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another reason is the "allocation override" that forces a variant value

@typotter

typotter commented Jan 19, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jan 19, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-01-19 17:37:32 UTC ℹ️ Start processing command /merge

2026-01-19 17:37:37 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-01-19 17:42:30 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in feature/flags-ofeat is approximately 1h (p90).

2026-01-19 18:49:20 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 6291697 into feature/flags-ofeat Jan 19, 2026
27 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the typo/add-static-resolution-reason-ofeat branch January 19, 2026 18:49
@ncreated
ncreated restored the typo/add-static-resolution-reason-ofeat branch April 9, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leoromanovsky leoromanovsky leoromanovsky approved these changes
@0xnm 0xnm 0xnm approved these changes
@jonathanmos jonathanmos jonathanmos approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@typotter @codecov-commenter @leoromanovsky @0xnm @jonathanmos