[Flags] feat: Add Openfeature Flags to test app. by typotter · Pull Request #3130 · DataDog/dd-sdk-android

typotter · 2026-01-16T18:35:39Z

What does this PR do?

This PR adds a screen for the OpenFeature Flagging Feature

Motivation

Allows testing and verification of the module.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Make sure you discussed the feature or bugfix with the maintaining team in an Issue
Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

datadog-datadog-prod-us1 · 2026-01-16T21:17:32Z

🎯 Code Coverage
• Patch Coverage: 100.00%
• Overall Coverage: 65.95% (-3.00%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 8f5ccaf | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

codecov-commenter · 2026-01-16T21:24:46Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.86%. Comparing base (6291697) to head (8f5ccaf).

Additional details and impacted files

@@                   Coverage Diff                   @@
##           feature/flags-ofeat    #3130      +/-   ##
=======================================================
- Coverage                70.87%   70.86%   -0.01%     
=======================================================
  Files                      899      899              
  Lines                    33138    33138              
  Branches                  5592     5592              
=======================================================
- Hits                     23485    23483       -2     
+ Misses                    8091     8089       -2     
- Partials                  1562     1566       +4

see 30 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

0xnm · 2026-01-19T08:12:07Z

+
+        // Set evaluation context on OpenFeatureAPI (provider forwards to FlagsClient)
+        val preferences = Preferences.defaultPreferences(this)
+        val userId = preferences.getUserId() ?: "anonymous-${System.currentTimeMillis()}"


On a scale anonymous-${System.currentTimeMillis()} would lead to the two different users having a same ID in case this was called the same timestamp.

So maybe it is better just to use UUID.

Agreed. Changed to uuid and added some more explanatory comments for developers

0xnm · 2026-01-19T08:15:51Z

-                if (BuildConfig.DD_OVERRIDE_RUM_URL.isNotBlank()) {
-                    useCustomEndpoint(BuildConfig.DD_OVERRIDE_RUM_URL)
-                }
+    private fun createRumConfiguration(): RumConfiguration = RumConfiguration.Builder(BuildConfig.DD_RUM_APPLICATION_ID)


nit: seems like it is unnecessary change

…/OpenFeatureFragment.kt Co-authored-by: Nikita Ogorodnikov <[email protected]>

typotter · 2026-01-19T18:13:53Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-01-19T18:13:57Z

View all feedbacks in Devflow UI.

2026-01-19 18:13:57 UTC ℹ️ Start processing command /merge

2026-01-19 18:14:01 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in typo/add-static-resolution-reason-ofeat is approximately 0s (p90).

2026-01-19 18:25:38 UTC ❌ MergeQueue: This merge request was updated

This PR is rejected because it was updated

typotter · 2026-01-19T18:26:08Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-01-19T18:26:11Z

View all feedbacks in Devflow UI.

2026-01-19 18:26:11 UTC ℹ️ Start processing command /merge

2026-01-19 18:26:14 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in typo/add-static-resolution-reason-ofeat is approximately 0s (p90).

2026-01-19 18:26:56 UTC ⚠️ MergeQueue: This merge request build was cancelled

[email protected] cancelled this merge request build

typotter · 2026-01-19T18:26:45Z

/merge --cancel

gh-worker-devflow-routing-ef8351 · 2026-01-19T18:26:49Z

View all feedbacks in Devflow UI.

2026-01-19 18:26:49 UTC ℹ️ Start processing command /merge --cancel

The base branch was changed.

typotter · 2026-01-19T18:50:47Z

thanks, and sorry @0xnm
I'll need another stamp after merging the stacked base branch, please and thank you

typotter · 2026-01-19T18:51:10Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-01-19T18:51:14Z

View all feedbacks in Devflow UI.

2026-01-19 18:51:14 UTC ℹ️ Start processing command /merge

2026-01-19 18:51:19 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-01-19 22:52:05 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

typotter · 2026-01-20T03:31:18Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-01-20T03:31:21Z

View all feedbacks in Devflow UI.

2026-01-20 03:31:21 UTC ℹ️ Start processing command /merge

2026-01-20 03:31:25 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-01-20 06:55:07 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in feature/flags-ofeat is approximately 1h (p90).

2026-01-20 07:47:50 UTC ℹ️ MergeQueue: This merge request was merged

typotter changed the title ~~feat: Add Openfeature Flags to test app.~~ [Flags] feat: Add Openfeature Flags to test app. Jan 16, 2026

typotter marked this pull request as ready for review January 16, 2026 22:48

typotter requested a review from a team as a code owner January 16, 2026 22:48

typotter added 5 commits January 16, 2026 16:29

feat: use openfeature flags in sample app

0e0b4d5

lint and detekt

3ab8fa6

clean diff

27876b9

default flag key

a7fd358

full imports

2b93324

typotter changed the base branch from feature/flags-ofeat to typo/add-static-resolution-reason-ofeat January 17, 2026 00:00

typotter force-pushed the typo/test-app-of-flags branch from 91c7644 to 2b93324 Compare January 17, 2026 00:00

refator details formatting

ccac06d

0xnm approved these changes Jan 19, 2026

View reviewed changes

typotter and others added 4 commits January 19, 2026 10:38

Update sample/kotlin/src/main/kotlin/com/datadog/android/sample/flags…

c5a8115

…/OpenFeatureFragment.kt Co-authored-by: Nikita Ogorodnikov <[email protected]>

fix: use UUID for anonymous uses

a39ad08

remove modern linted block

6498b6e

fix: bad format and locale import

21c9e52

dd-devflow Bot added mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: queued labels Jan 19, 2026

fix import

932408d

dd-devflow Bot added mergequeue-status: rejected and removed mergequeue-status: in_progress labels Jan 19, 2026

dd-devflow Bot added mergequeue-status: queued and removed mergequeue-status: rejected labels Jan 19, 2026

dd-devflow Bot added the mergequeue-status: in_progress label Jan 19, 2026

dd-devflow Bot added mergequeue-status: removed and removed mergequeue-status: in_progress labels Jan 19, 2026

0xnm previously approved these changes Jan 19, 2026

View reviewed changes

Base automatically changed from typo/add-static-resolution-reason-ofeat to feature/flags-ofeat January 19, 2026 18:49

typotter requested a review from 0xnm January 19, 2026 18:50

dd-devflow Bot added mergequeue-status: waiting mergequeue-status: removed and removed mergequeue-status: removed mergequeue-status: waiting labels Jan 19, 2026

Merge branch 'feature/flags-ofeat' into typo/test-app-of-flags

8f5ccaf

dd-devflow Bot added mergequeue-status: waiting and removed mergequeue-status: removed labels Jan 20, 2026

0xnm approved these changes Jan 20, 2026

View reviewed changes

dd-devflow Bot added mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: waiting mergequeue-status: queued labels Jan 20, 2026

dd-mergequeue Bot merged commit 2c44cf4 into feature/flags-ofeat Jan 20, 2026
27 checks passed

dd-devflow Bot removed the mergequeue-status: in_progress label Jan 20, 2026

dd-mergequeue Bot deleted the typo/test-app-of-flags branch January 20, 2026 07:47

dd-devflow Bot added the mergequeue-status: done label Jan 20, 2026

Uh oh!

Conversation

typotter commented Jan 16, 2026

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

Uh oh!

datadog-datadog-prod-us1 Bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

0xnm Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

typotter Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

0xnm Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

typotter Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

typotter commented Jan 19, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typotter commented Jan 19, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typotter commented Jan 19, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typotter commented Jan 19, 2026

Uh oh!

typotter commented Jan 19, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typotter commented Jan 20, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

datadog-datadog-prod-us1 Bot commented Jan 16, 2026 •

edited

Loading

codecov-commenter commented Jan 16, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Jan 19, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Jan 19, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Jan 19, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Jan 19, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Jan 20, 2026 •

edited

Loading