Skip to content

Mark fatal ANR as processed before RUM events are written#3129

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/mark-fatal-anr-as-processed-before-rum-events-written
Jan 16, 2026
Merged

Mark fatal ANR as processed before RUM events are written#3129
0xnm merged 1 commit into
developfrom
nogorodnikov/mark-fatal-anr-as-processed-before-rum-events-written

Conversation

@0xnm

@0xnm 0xnm commented Jan 16, 2026

Copy link
Copy Markdown
Member

What does this PR do?

This is attempt to fix a case of double-sending fatal ANR. Probably it can happen if RUM events are written but there is an issue between RUM events write and marking ANR as processed preventing the latter.

Let's try to mark ANR as processed first.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner January 16, 2026 10:09
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jan 16, 2026

Copy link
Copy Markdown

🎯 Code Coverage
Patch Coverage: 100.00%
Overall Coverage: 65.84% (+0.04%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c82c7f1 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.80%. Comparing base (21d5005) to head (c82c7f1).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3129      +/-   ##
===========================================
+ Coverage    70.75%   70.80%   +0.04%     
===========================================
  Files          893      893              
  Lines        33000    33000              
  Branches      5549     5549              
===========================================
+ Hits         23349    23363      +14     
+ Misses        8099     8095       -4     
+ Partials      1552     1542      -10     
Files with missing lines Coverage Δ
...g/android/rum/internal/DatadogLateCrashReporter.kt 90.00% <100.00%> (ø)

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm merged commit 6c11581 into develop Jan 16, 2026
27 checks passed
@0xnm
0xnm deleted the nogorodnikov/mark-fatal-anr-as-processed-before-rum-events-written branch January 16, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants