Skip to content

Drop Rum prefix for the generated Vital models#3125

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/drop-rum-prefix-for-vital-models
Jan 14, 2026
Merged

Drop Rum prefix for the generated Vital models#3125
0xnm merged 1 commit into
developfrom
nogorodnikov/drop-rum-prefix-for-vital-models

Conversation

@0xnm

@0xnm 0xnm commented Jan 14, 2026

Copy link
Copy Markdown
Member

What does this PR do?

This change is done in order to align with existing RUM models naming convention.

It is a backward-compatible change, because aliases are introduced.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner January 14, 2026 16:47
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jan 14, 2026 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown

🎯 Code Coverage
• Patch Coverage: 93.46%
• Overall Coverage: 65.80% (-0.01%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 18431e1 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter

codecov-commenter commented Jan 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.71963% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.72%. Comparing base (c1d8da1) to head (18431e1).
⚠️ Report is 693 commits behind head on develop.

Files with missing lines Patch % Lines
...g/android/rum/internal/domain/scope/RumEventExt.kt 84.91% 8 Missing ⚠️
...ernal/domain/scope/RumVitalAppLaunchEventHelper.kt 84.21% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3125      +/-   ##
===========================================
+ Coverage    70.69%   70.72%   +0.02%     
===========================================
  Files          893      893              
  Lines        33000    33000              
  Branches      5549     5549              
===========================================
+ Hits         23329    23337       +8     
+ Misses        8122     8111      -11     
- Partials      1549     1552       +3
Files with missing lines Coverage Δ
...kotlin/com/datadog/android/rum/RumConfiguration.kt 94.38% <100.00%> (ø)
...lin/com/datadog/android/rum/internal/RumFeature.kt 90.16% <100.00%> (+0.70%) ⬆️
.../datadog/android/rum/internal/RumSessionTypeExt.kt 100.00% <100.00%> (ø)
...ndroid/rum/internal/domain/event/RumEventMapper.kt 100.00% <100.00%> (ø)
...id/rum/internal/domain/event/RumEventSerializer.kt 94.09% <100.00%> (ø)
.../android/rum/internal/domain/scope/RumViewScope.kt 94.43% <100.00%> (+0.11%) ⬆️
.../internal/startup/RumSessionScopeStartupManager.kt 96.19% <100.00%> (ø)
...ernal/domain/scope/RumVitalAppLaunchEventHelper.kt 88.42% <84.21%> (ø)
...g/android/rum/internal/domain/scope/RumEventExt.kt 93.80% <84.91%> (+0.50%) ⬆️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm merged commit 21d5005 into develop Jan 14, 2026
26 checks passed
@0xnm
0xnm deleted the nogorodnikov/drop-rum-prefix-for-vital-models branch January 14, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aleksandr-gringauz aleksandr-gringauz aleksandr-gringauz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0xnm @codecov-commenter @aleksandr-gringauz