Skip to content

Use a single gradle command for customDetektRules#3123

Merged
aleksandr-gringauz merged 1 commit into
developfrom
aleksandr-gringauz/single-gradle-command-for-custom-detekt-rules
Jan 13, 2026
Merged

Use a single gradle command for customDetektRules#3123
aleksandr-gringauz merged 1 commit into
developfrom
aleksandr-gringauz/single-gradle-command-for-custom-detekt-rules

Conversation

@aleksandr-gringauz

@aleksandr-gringauz aleksandr-gringauz commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

We can use a single gradle command to run the task in all gradle subprojects https://docs.gradle.org/current/userguide/multi_project_builds_intermediate.html#sec:executing_tasks_by_name.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jan 12, 2026

Copy link
Copy Markdown

🎯 Code Coverage
Patch Coverage: 91.89%
Overall Coverage: 65.79% (-0.02%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 53466ef | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter

codecov-commenter commented Jan 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.72%. Comparing base (b345b6e) to head (53466ef).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3123      +/-   ##
===========================================
+ Coverage    70.69%   70.72%   +0.02%     
===========================================
  Files          893      893              
  Lines        33000    33000              
  Branches      5549     5549              
===========================================
+ Hits         23329    23336       +7     
+ Misses        8120     8109      -11     
- Partials      1551     1555       +4     

see 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aleksandr-gringauz
aleksandr-gringauz force-pushed the aleksandr-gringauz/single-gradle-command-for-custom-detekt-rules branch from b39b0b4 to 53466ef Compare January 13, 2026 15:35
@aleksandr-gringauz
aleksandr-gringauz marked this pull request as ready for review January 13, 2026 15:39
@aleksandr-gringauz
aleksandr-gringauz requested a review from a team as a code owner January 13, 2026 15:39

@0xnm 0xnm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original reason for splitting it was getting Out Of Memory error (occasionally) when all tasks are run at once.

Let's see if we hit it still or not.

@aleksandr-gringauz

Copy link
Copy Markdown
Contributor Author

Let's see if we hit it still or not.

Yes, let's keep an eye on it. IIUC in CI gradle isn't running things in parallel, because this isn't enabled, so I'm not sure how it can start using too much memory.

@aleksandr-gringauz
aleksandr-gringauz merged commit c1d8da1 into develop Jan 13, 2026
26 checks passed
@aleksandr-gringauz
aleksandr-gringauz deleted the aleksandr-gringauz/single-gradle-command-for-custom-detekt-rules branch January 13, 2026 16:40
@0xnm

0xnm commented Jan 13, 2026

Copy link
Copy Markdown
Member

I mean it was still a single Gradle daemon invocation, so maybe some memory wasn't collected when a module task completes, or there is some in-memory growing cache. It wasn't about parallel tasks execution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants