Skip to content

Remove unused FileOrchestrator.getRootDirName API#3108

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/remove-getrootdirname-api
Jan 7, 2026
Merged

Remove unused FileOrchestrator.getRootDirName API#3108
0xnm merged 1 commit into
developfrom
nogorodnikov/remove-getrootdirname-api

Conversation

@0xnm

@0xnm 0xnm commented Jan 7, 2026

Copy link
Copy Markdown
Member

What does this PR do?

This API was added for a very specific use-case and not used anymore.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner January 7, 2026 09:22
@datadog-official

datadog-official Bot commented Jan 7, 2026

Copy link
Copy Markdown

🎯 Code Coverage
Patch Coverage: 100.00%
Overall Coverage: 66.45% (-0.02%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: add328a | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.49%. Comparing base (7b2040f) to head (add328a).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3108      +/-   ##
===========================================
+ Coverage    71.46%   71.49%   +0.03%     
===========================================
  Files          881      881              
  Lines        32510    32507       -3     
  Branches      5480     5479       -1     
===========================================
+ Hits         23233    23239       +6     
+ Misses        7735     7728       -7     
+ Partials      1542     1540       -2     
Files with missing lines Coverage Δ
...ence/file/advanced/ConsentAwareFileOrchestrator.kt 87.10% <ø> (-0.40%) ⬇️
...al/persistence/file/batch/BatchFileOrchestrator.kt 92.90% <ø> (-0.05%) ⬇️
.../persistence/file/single/SingleFileOrchestrator.kt 73.33% <ø> (-1.67%) ⬇️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm merged commit cd9f2dd into develop Jan 7, 2026
27 checks passed
@0xnm
0xnm deleted the nogorodnikov/remove-getrootdirname-api branch January 7, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants