FFL-1675: [Flags] Add support for global flags via EvaluationContext.EMPTY by typotter · Pull Request #3104 · DataDog/dd-sdk-android

typotter · 2026-01-05T22:35:47Z

What does this PR do?

Adds EvaluationContext.EMPTY constant to support global flag evaluations without user-specific targeting context.

This PR also includes a couple of minor fixes in the flags module.

Motivation

The Open Feature spec does not require a tarketingKey for flag evaluation. Our flags module requires a non-null key so that it may compute bucketing. An empty string is a valid targeting key, so this EMPTY context is a handy shortcut for when a non-null-but-empty context is required.

The NoopFlagsClient is expected to start in a NotReady state, rather than an error. This missing expectation surfaced in openfeature module testing.

Additional Notes

Use Cases

// Evaluate a global flag without any user context
client.setEvaluationContext(EvaluationContext.EMPTY)
val globalFeature = client.resolveBooleanValue("global-feature", false)

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Make sure you discussed the feature or bugfix with the maintaining team in an Issue
Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

datadog-official · 2026-01-05T23:21:55Z

🎯 Code Coverage
• Patch Coverage: 100.00%
• Overall Coverage: 66.49% (+0.01%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 95c4410 | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

typotter

Thanks! ptal for the fixes applied

typotter · 2026-01-06T08:27:35Z

/merge

dd-devflow-routing-codex · 2026-01-06T08:27:38Z

View all feedbacks in Devflow UI.

2026-01-06 08:27:38 UTC ℹ️ Start processing command /merge

2026-01-06 08:27:42 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-01-06 12:28:12 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

typotter

Thanks Nikita. Just needs a stamp for the last tweaks please and thank you

typotter · 2026-01-06T16:27:52Z

/merge

dd-devflow-routing-codex · 2026-01-06T16:27:56Z

View all feedbacks in Devflow UI.

2026-01-06 16:27:56 UTC ℹ️ Start processing command /merge

2026-01-06 16:28:04 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-01-06 16:50:41 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

typotter · 2026-01-06T16:50:29Z

/remove

dd-devflow-routing-codex · 2026-01-06T16:50:32Z

View all feedbacks in Devflow UI.

2026-01-06 16:50:32 UTC ℹ️ Start processing command /remove

2026-01-06 16:50:39 UTC ℹ️ Devflow: /remove

typotter · 2026-01-06T19:13:23Z

/remove

dd-devflow-routing-codex · 2026-01-06T19:13:26Z

View all feedbacks in Devflow UI.

2026-01-06 19:13:26 UTC ℹ️ Start processing command /remove

2026-01-06 19:13:29 UTC ℹ️ Devflow: /remove

Co-authored-by: Nikita Ogorodnikov <[email protected]>

codecov-commenter · 2026-01-06T19:54:10Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.48%. Comparing base (d370277) to head (95c4410).
⚠️ Report is 16 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3104      +/-   ##
===========================================
+ Coverage    71.42%   71.48%   +0.07%     
===========================================
  Files          881      881              
  Lines        32523    32524       +1     
  Branches      5479     5479              
===========================================
+ Hits         23227    23249      +22     
+ Misses        7747     7738       -9     
+ Partials      1549     1537      -12

Files with missing lines	Coverage Δ
.../datadog/android/flags/internal/NoOpFlagsClient.kt	`93.33% <100.00%> (ø)`
...m/datadog/android/flags/model/EvaluationContext.kt	`100.00% <100.00%> (ø)`
...om/datadog/android/flags/model/FlagsClientState.kt	`83.33% <ø> (ø)`

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

typotter · 2026-01-07T15:19:47Z

/merge

dd-devflow-routing-codex · 2026-01-07T15:19:54Z

View all feedbacks in Devflow UI.

2026-01-07 15:19:53 UTC ℹ️ Start processing command /merge

2026-01-07 15:20:01 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in develop is approximately 1h (p90).

2026-01-07 16:21:35 UTC ℹ️ MergeQueue: This merge request was merged

typotter requested a review from a team as a code owner January 5, 2026 22:35

typotter added a commit that referenced this pull request Jan 5, 2026

Remove EvaluationContext.EMPTY (moved to PR #3104)

97a31fb

typotter mentioned this pull request Jan 5, 2026

[Flags/openfeature] Add openfeature type conversion utilities #3103

Merged

3 tasks

typotter changed the title ~~FFL-1675: Add support for global flags via EvaluationContext.EMPTY~~ FFL-1675: [Flags] Add support for global flags via EvaluationContext.EMPTY Jan 5, 2026

typotter force-pushed the typo/FFL-1675-sdk-android-support-global branch from c5e45ae to e398b27 Compare January 5, 2026 22:43

typotter added a commit that referenced this pull request Jan 6, 2026

Remove EvaluationContext.EMPTY (moved to PR #3104)

8cb54e1

typotter changed the base branch from feature/flags-ofeat to develop January 6, 2026 07:21

typotter force-pushed the typo/FFL-1675-sdk-android-support-global branch from 33caa77 to 707ac12 Compare January 6, 2026 07:28

0xnm previously approved these changes Jan 6, 2026

View reviewed changes

typotter dismissed 0xnm’s stale review via a60b216 January 6, 2026 08:18

typotter commented Jan 6, 2026

View reviewed changes

Comment thread ...-android-flags/src/main/kotlin/com/datadog/android/flags/internal/ExposureEventsProcessor.kt Outdated

Comment thread ...k-android-flags/src/test/kotlin/com/datadog/android/flags/internal/DatadogFlagsClientTest.kt Outdated

typotter requested a review from 0xnm January 6, 2026 08:21

dd-devflow Bot added the mergequeue-status: waiting label Jan 6, 2026

0xnm previously approved these changes Jan 6, 2026

View reviewed changes

Comment thread ...k-android-flags/src/test/kotlin/com/datadog/android/flags/internal/DatadogFlagsClientTest.kt Outdated

dd-devflow Bot added mergequeue-status: removed and removed mergequeue-status: waiting labels Jan 6, 2026

typotter dismissed 0xnm’s stale review via 0bc3963 January 6, 2026 16:20

typotter commented Jan 6, 2026

View reviewed changes

0xnm previously approved these changes Jan 6, 2026

View reviewed changes

dd-devflow Bot added mergequeue-status: waiting and removed mergequeue-status: removed labels Jan 6, 2026

typotter dismissed 0xnm’s stale review via 6a1b3c7 January 6, 2026 16:46

typotter requested a review from 0xnm January 6, 2026 16:47

dd-devflow Bot added mergequeue-status: removed and removed mergequeue-status: waiting labels Jan 6, 2026

typotter and others added 12 commits January 6, 2026 12:13

feat: empty context constant

f12ec28

fix: default state of Noop client

f07d929

lint module

5cca011

remove structured value overide

c4822e6

docs: flag client state

5ac060e

Apply suggestions from code review

5079814

Co-authored-by: Nikita Ogorodnikov <[email protected]>

un-necessary change

a2e15a4

test refine

08d8659

refine and api

2269bcb

flags api gen files

870cc31

import

ef92c0f

lint

95c4410

typotter force-pushed the typo/FFL-1675-sdk-android-support-global branch from 52ec66f to 95c4410 Compare January 6, 2026 19:14

0xnm approved these changes Jan 7, 2026

View reviewed changes

dd-devflow Bot added mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: removed mergequeue-status: queued labels Jan 7, 2026

dd-mergequeue Bot merged commit 04c833a into develop Jan 7, 2026
27 checks passed

dd-mergequeue Bot deleted the typo/FFL-1675-sdk-android-support-global branch January 7, 2026 16:21

dd-devflow Bot added mergequeue-status: done and removed mergequeue-status: in_progress labels Jan 7, 2026

typotter added a commit that referenced this pull request Jan 8, 2026

Merge feature/flags-ofeat with merged PRs (#3103, #3104, #3068)

2328698

Uh oh!

Conversation

typotter commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Additional Notes

Use Cases

Related

Review checklist (to be filled by reviewers)

Uh oh!

datadog-official Bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

typotter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

typotter commented Jan 6, 2026

Uh oh!

dd-devflow-routing-codex Bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

typotter left a comment

Choose a reason for hiding this comment

Uh oh!

typotter commented Jan 6, 2026

Uh oh!

dd-devflow-routing-codex Bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typotter commented Jan 6, 2026

Uh oh!

dd-devflow-routing-codex Bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typotter commented Jan 6, 2026

Uh oh!

dd-devflow-routing-codex Bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Jan 6, 2026

Codecov Report

Uh oh!

typotter commented Jan 7, 2026

Uh oh!

dd-devflow-routing-codex Bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

typotter commented Jan 5, 2026 •

edited

Loading

datadog-official Bot commented Jan 5, 2026 •

edited

Loading

dd-devflow-routing-codex Bot commented Jan 6, 2026 •

edited

Loading

dd-devflow-routing-codex Bot commented Jan 6, 2026 •

edited

Loading

dd-devflow-routing-codex Bot commented Jan 6, 2026 •

edited

Loading

dd-devflow-routing-codex Bot commented Jan 6, 2026 •

edited

Loading

dd-devflow-routing-codex Bot commented Jan 7, 2026 •

edited

Loading