[Flags/openfeature] Add openfeature type conversion utilities by typotter · Pull Request #3103 · DataDog/dd-sdk-android

typotter · 2026-01-05T22:08:59Z

What does this PR do?

Adds the complete type conversion layer for structured flags and OpenFeature integration, including JSON-to-Map utilities and OpenFeature Value converters.

Context

In order to break #2998 down a bit into mergeable chunks, this PR contains the type conversion logic

Additional Notes

Extracted from feat: Openfeature Provider implementation powered by DD Flags #2998
Follows PR FFL-1621 Fix: set currentState in a blocking call #3068 (State Management)
FFL-1675: [Flags] Add support for global flags via EvaluationContext.EMPTY #3104 (EvaluationContext.EMPTY for global flags)

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Make sure you discussed the feature or bugfix with the maintaining team in an Issue
Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

0xnm · 2026-01-06T08:46:39Z

+    // region convertMapToValue
+
+    @Test
+    fun `M convert empty Map W convertMapToValue(, mockInternalLogger) {empty map}`() {


unexpected comma after the opening bracket here and below as well

Co-authored-by: Nikita Ogorodnikov <[email protected]>

typotter · 2026-01-07T15:54:25Z

/merge

dd-devflow-routing-codex · 2026-01-07T15:54:30Z

View all feedbacks in Devflow UI.

2026-01-07 15:54:29 UTC ℹ️ Start processing command /merge

2026-01-07 15:54:54 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-01-07 19:55:12 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

datadog-official · 2026-01-07T16:01:27Z

🎯 Code Coverage
• Patch Coverage: 57.83%
• Overall Coverage: 65.88% (+0.06%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: e1bc541 | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

…conversions

typotter · 2026-01-07T20:34:10Z

/merge

dd-devflow-routing-codex · 2026-01-07T20:34:15Z

View all feedbacks in Devflow UI.

2026-01-07 20:34:15 UTC ℹ️ Start processing command /merge

2026-01-07 20:34:20 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-01-07 21:26:26 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in feature/flags-ofeat is approximately 1h (p90).

2026-01-07 22:31:26 UTC ℹ️ MergeQueue: This merge request was merged

codecov-commenter · 2026-01-07T21:10:18Z

Codecov Report

❌ Patch coverage is 81.81818% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.74%. Comparing base (3099ab5) to head (e1bc541).

Files with missing lines	Patch %	Lines
.../flags/openfeature/internal/adapters/Converters.kt	55.56%	7 Missing and 1 partial ⚠️

Additional details and impacted files

@@                   Coverage Diff                   @@
##           feature/flags-ofeat    #3103      +/-   ##
=======================================================
+ Coverage                70.70%   70.74%   +0.04%     
=======================================================
  Files                      895      897       +2     
  Lines                    33030    33074      +44     
  Branches                  5562     5578      +16     
=======================================================
+ Hits                     23352    23397      +45     
- Misses                    8111     8116       +5     
+ Partials                  1567     1561       -6

Files with missing lines	Coverage Δ
...s/openfeature/internal/adapters/ValueConverters.kt	`100.00% <100.00%> (ø)`
.../flags/openfeature/internal/adapters/Converters.kt	`55.56% <55.56%> (ø)`

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

typotter requested a review from a team as a code owner January 5, 2026 22:09

typotter marked this pull request as draft January 5, 2026 22:14

typotter force-pushed the typo/flags-data-objects-type-conversions branch from e4ea34a to edb9980 Compare January 5, 2026 22:24

typotter changed the title ~~feat: Add data objects and type conversion utilities~~ feat: [Flags/openfeature] Add data objects and type conversion utilities Jan 5, 2026

typotter changed the base branch from feature/flags-ofeat to typo/FFL-1675-sdk-android-support-global January 6, 2026 07:12

typotter force-pushed the typo/flags-data-objects-type-conversions branch from 97a31fb to c506ec5 Compare January 6, 2026 07:19

typotter force-pushed the typo/FFL-1675-sdk-android-support-global branch from 33caa77 to 707ac12 Compare January 6, 2026 07:28

typotter changed the base branch from typo/FFL-1675-sdk-android-support-global to feature/flags-ofeat January 6, 2026 07:31

typotter force-pushed the typo/flags-data-objects-type-conversions branch from d3c25eb to 3319899 Compare January 6, 2026 07:45

feat: converters for openfeature values

14ad1cb

typotter force-pushed the typo/flags-data-objects-type-conversions branch from 3319899 to 14ad1cb Compare January 6, 2026 07:45

typotter marked this pull request as ready for review January 6, 2026 07:49

0xnm reviewed Jan 6, 2026

View reviewed changes

jonathanmos reviewed Jan 6, 2026

View reviewed changes

Comment thread detekt_custom_safe_calls.yml Outdated

typotter and others added 5 commits January 6, 2026 09:08

revert safe calls

993d044

Apply suggestions from code review

941bd49

Co-authored-by: Nikita Ogorodnikov <[email protected]>

revert safe calls list

db70625

unrelated change

8be96e9

simplify converter interface

d233f26

typotter requested review from 0xnm and jonathanmos January 6, 2026 17:49

typotter changed the title ~~feat: [Flags/openfeature] Add data objects and type conversion utilities~~ [Flags/openfeature] Add openfeature type conversion utilities Jan 6, 2026

typotter added 2 commits January 6, 2026 12:08

safe calls

723520a

shuffle block to appease lint for annotation

e4eb117

0xnm previously approved these changes Jan 7, 2026

View reviewed changes

Comment thread ...c/test/kotlin/com/datadog/android/flags/openfeature/internal/adapters/ValueConvertersTest.kt Outdated

typotter added 2 commits January 7, 2026 08:22

test: verify warning on mocklogger

6f35194

missing buitin methods

487f61c

typotter dismissed 0xnm’s stale review via 487f61c January 7, 2026 15:33

0xnm previously approved these changes Jan 7, 2026

View reviewed changes

dd-devflow Bot added the mergequeue-status: waiting label Jan 7, 2026

fix matchers in test

47b0038

typotter dismissed 0xnm’s stale review via 47b0038 January 7, 2026 16:40

typotter requested a review from 0xnm January 7, 2026 16:41

0xnm approved these changes Jan 7, 2026

View reviewed changes

dd-devflow Bot added mergequeue-status: removed and removed mergequeue-status: waiting labels Jan 7, 2026

Merge branch 'feature/flags-ofeat' into typo/flags-data-objects-type-…

e1bc541

…conversions

dd-devflow Bot added mergequeue-status: waiting and removed mergequeue-status: removed labels Jan 7, 2026

dd-devflow Bot added mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: waiting mergequeue-status: queued labels Jan 7, 2026

dd-mergequeue Bot merged commit a480f11 into feature/flags-ofeat Jan 7, 2026
27 checks passed

dd-devflow Bot removed the mergequeue-status: in_progress label Jan 7, 2026

dd-mergequeue Bot deleted the typo/flags-data-objects-type-conversions branch January 7, 2026 22:31

dd-devflow Bot added the mergequeue-status: done label Jan 7, 2026

typotter added a commit that referenced this pull request Jan 8, 2026

Merge feature/flags-ofeat with merged PRs (#3103, #3104, #3068)

2328698

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Flags/openfeature] Add openfeature type conversion utilities#3103

[Flags/openfeature] Add openfeature type conversion utilities#3103
dd-mergequeue[bot] merged 12 commits into
feature/flags-ofeatfrom
typo/flags-data-objects-type-conversions

typotter commented Jan 5, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

0xnm Jan 6, 2026

Uh oh!

typotter Jan 6, 2026

Uh oh!

Uh oh!

Uh oh!

typotter commented Jan 7, 2026

Uh oh!

dd-devflow-routing-codex Bot commented Jan 7, 2026 •

edited

Loading

Uh oh!

datadog-official Bot commented Jan 7, 2026 •

edited by datadog-datadog-prod-us1 Bot

Loading

Uh oh!

typotter commented Jan 7, 2026

Uh oh!

dd-devflow-routing-codex Bot commented Jan 7, 2026 •

edited

Loading

Uh oh!

codecov-commenter commented Jan 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

typotter commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Context

Additional Notes

Review checklist (to be filled by reviewers)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

0xnm Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

typotter Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

typotter commented Jan 7, 2026

Uh oh!

dd-devflow-routing-codex Bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

datadog-official Bot commented Jan 7, 2026 • edited by datadog-datadog-prod-us1 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typotter commented Jan 7, 2026

Uh oh!

dd-devflow-routing-codex Bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Jan 7, 2026

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

typotter commented Jan 5, 2026 •

edited

Loading

dd-devflow-routing-codex Bot commented Jan 7, 2026 •

edited

Loading

datadog-official Bot commented Jan 7, 2026 •

edited by datadog-datadog-prod-us1 Bot

Loading

dd-devflow-routing-codex Bot commented Jan 7, 2026 •

edited

Loading