Skip to content

RUM-10684: Remove ApiLevelExtension#3095

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/rum-10684/remove-apilevelextension
Jan 5, 2026
Merged

RUM-10684: Remove ApiLevelExtension#3095
0xnm merged 1 commit into
developfrom
nogorodnikov/rum-10684/remove-apilevelextension

Conversation

@0xnm

@0xnm 0xnm commented Jan 2, 2026

Copy link
Copy Markdown
Member

What does this PR do?

This PR removes ApiLevelExtension which was used to set Build.VERSION.SDK_INT property for tests.

Since Build.VERSION.SDK_INT is a static final field, after some time it can be inlined by JIT and modifications are not effective anymore.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jan 2, 2026 •
edited
Loading

Copy link
Copy Markdown

🎯 Code Coverage
• Patch Coverage: 79.27%
• Overall Coverage: 66.50% (+0.03%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 85a86f1 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter

codecov-commenter commented Jan 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.66667% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.46%. Comparing base (17c117e) to head (85a86f1).

Files with missing lines Patch % Lines
...android/internal/system/BuildSdkVersionProvider.kt 0.00% 9 Missing ⚠️
...droid/rum/internal/vitals/FrameStatesAggregator.kt 50.00% 0 Missing and 3 partials ⚠️
.../rum/internal/startup/RumAppStartupDetectorImpl.kt 0.00% 0 Missing and 2 partials ⚠️
...sessionreplay/internal/recorder/WindowInspector.kt 50.00% 0 Missing and 1 partial ⚠️
...nal/recorder/resources/BitmapSignatureGenerator.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3095      +/-   ##
===========================================
+ Coverage    71.40%   71.46%   +0.06%     
===========================================
  Files          881      881              
  Lines        32460    32479      +19     
  Branches      5466     5473       +7     
===========================================
+ Hits         23178    23211      +33     
+ Misses        7729     7715      -14     
  Partials      1553     1553
Files with missing lines Coverage Δ
...n/com/datadog/android/core/internal/CoreFeature.kt 84.99% <100.00%> (+0.04%) ⬆️
...n/com/datadog/android/core/internal/DatadogCore.kt 77.66% <100.00%> (ø)
...l/net/info/BroadcastReceiverNetworkInfoProvider.kt 96.88% <100.00%> (ø)
...e/internal/net/info/CallbackNetworkInfoProvider.kt 95.06% <100.00%> (ø)
...droid/core/internal/receiver/ThreadSafeReceiver.kt 100.00% <100.00%> (ø)
...core/internal/system/DefaultAndroidInfoProvider.kt 80.52% <100.00%> (ø)
.../core/internal/time/DefaultAppStartTimeProvider.kt 100.00% <100.00%> (ø)
...lin/com/datadog/android/rum/internal/RumFeature.kt 89.79% <100.00%> (+0.05%) ⬆️
...ernal/domain/battery/DefaultBatteryInfoProvider.kt 83.33% <100.00%> (+4.26%) ⬆️
...roid/rum/internal/startup/RumAppStartupDetector.kt 100.00% <ø> (ø)
... and 17 more

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm marked this pull request as ready for review January 2, 2026 14:24
@0xnm
0xnm requested a review from a team as a code owner January 2, 2026 14:24
ambushwork
ambushwork previously approved these changes Jan 5, 2026
View reviewed changes
Comment thread ...ndroid-internal/src/main/java/com/datadog/android/internal/system/BuildSdkVersionProvider.kt Outdated
@0xnm
0xnm force-pushed the nogorodnikov/rum-10684/remove-apilevelextension branch from bd44e9a to 10daac6 Compare January 5, 2026 14:16
@0xnm
0xnm requested a review from ambushwork January 5, 2026 14:16
ambushwork
ambushwork previously approved these changes Jan 5, 2026
View reviewed changes

@ambushwork ambushwork left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0xnm
0xnm force-pushed the nogorodnikov/rum-10684/remove-apilevelextension branch from 10daac6 to 043d4d7 Compare January 5, 2026 15:00
@0xnm
0xnm requested a review from ambushwork January 5, 2026 15:00
@0xnm

0xnm commented Jan 5, 2026

Copy link
Copy Markdown
Member Author

@ambushwork I had to rebase this PR due to the conflicts with develop branch. Can you please review it again?

ambushwork
ambushwork previously approved these changes Jan 5, 2026
View reviewed changes
@0xnm
0xnm dismissed stale reviews from aleksandr-gringauz and ambushwork via 85a86f1 January 5, 2026 15:56
@0xnm
0xnm force-pushed the nogorodnikov/rum-10684/remove-apilevelextension branch from 043d4d7 to 85a86f1 Compare January 5, 2026 15:56
@0xnm

0xnm commented Jan 5, 2026

Copy link
Copy Markdown
Member Author

Now solving sudden Cronet update which happened in the last minutes and deprecated Proxy constructor.

satween
satween approved these changes Jan 5, 2026
View reviewed changes

@satween satween left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed Cronet tests, all good from this perspective

@0xnm
0xnm merged commit 40ca37c into develop Jan 5, 2026
26 checks passed
@0xnm
0xnm deleted the nogorodnikov/rum-10684/remove-apilevelextension branch January 5, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@satween satween satween approved these changes
@ambushwork ambushwork ambushwork approved these changes
@aleksandr-gringauz aleksandr-gringauz aleksandr-gringauz left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@0xnm @codecov-commenter @satween @ambushwork @aleksandr-gringauz