RUM-12387: Slight refactoring of RUM schema cloning and parser generation tasks by aleksandr-gringauz · Pull Request #3094 · DataDog/dd-sdk-android

aleksandr-gringauz · 2026-01-02T10:43:12Z

What does this PR do?

This PR introduces changes the are needed for this PR to work. Read the description there to understand what we are trying to do.

Here we introduce 2 new Gradle tasks:

cloneAllRumSchemas task that runs all rum-events-format cloning tasks in different modules.
generateAllJsonModels that generates all JSON serialization/deserialization code in the project.

These 2 tasks are used in the PR in rum-events-format repo mentioned above.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Make sure you discussed the feature or bugfix with the maintaining team in an Issue
Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

datadog-official · 2026-01-02T11:12:08Z

🎯 Code Coverage
• Patch Coverage: 100.00%
• Overall Coverage: 71.48% (+4.97%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: ebd311a | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

codecov-commenter · 2026-01-02T11:26:27Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.46%. Comparing base (7eda91f) to head (ebd311a).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3094      +/-   ##
===========================================
- Coverage    71.47%   71.46%   -0.01%     
===========================================
  Files          881      881              
  Lines        32460    32460              
  Branches      5466     5466              
===========================================
- Hits         23200    23196       -4     
+ Misses        7715     7712       -3     
- Partials      1545     1552       +7

see 41 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

aleksandr-gringauz · 2026-01-02T12:08:25Z

@codex review

chatgpt-codex-connector · 2026-01-02T12:13:07Z

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aleksandr-gringauz · 2026-01-02T12:28:10Z

+    destinationFolder: String,
+    excludedPrefixes: List<String> = emptyList()
+) {
+    val repositoryRef = project.findProperty("dd.rum.schema.ref") as? String ?: "master"


This dd.rum.schema.ref argument is used here.

0xnm · 2026-01-02T14:02:50Z

+private const val CLONE_ALL_RUM_SCHEMAS_TASK_NAME = "cloneAllRumSchemas"
+private const val GENERATE_ALL_JSON_MODELS_TASK_NAME = "generateAllJsonModels"
+
+fun Project.createRumSchemaCloningTask(


nit: just for wording consistency

Suggested change

fun Project.createRumSchemaCloningTask(

fun Project.createRumSchemaCloneTask(

0xnm · 2026-01-02T14:18:22Z

+
+    rootTask.dependsOn(task)
+
+    afterEvaluate {


I think we have an opportunity to ditch afterEvaluate usage here if we replace tasks.findByName(ApiSurfacePlugin.TASK_GEN_KOTLIN_API_SURFACE) with tasks.withType<...>().all { dependsOn(taskName) }. Same for below.

But maybe I'm wrong, didn't try it by myself.

Removed afterEvaluate.

Changed to lazy api tasks.findByName(ApiSurfacePlugin.TASK_GEN_KOTLIN_API_SURFACE) -> tasks.withType(GenerateApiSurfaceTask::class.java).configureEach.

Also moved these tasks.withType(SourceJarTask::class.java) here. I think it is better to have this for all modules. Yes, if we use KSP in the module, we have a dependency between SourceJarTask and the task generating the code for JSON schemas even without this, but it looks like pure luck and IMHO is quite error prone.

Proof that it works https://gist.github.com/aleksandr-gringauz/5e4d05f041df787a7a73bed934ec0158.

0xnm · 2026-01-02T14:22:09Z

we need to delete this file instead, I forgot to do it in https://github.com/DataDog/dd-sdk-android/pull/2859/files

0xnm · 2026-01-02T14:23:03Z

Same as my comment above, we need to delete this file

…tion tasks

0xnm · 2026-01-02T17:46:06Z

+
+    rootTask.dependsOn(task)
+
+    tasks.withType(GenerateApiSurfaceTask::class.java).configureEach {


there is also a bit shorter Kotlin DSL for that (similar to register calls above)

dd-sdk-android/buildSrc/src/main/kotlin/com/datadog/gradle/plugin/apisurface/ApiSurfacePlugin.kt

Line 59 in 7eda91f

target.tasks.withType<KotlinCompile>() {

but no need to change anything

aleksandr-gringauz force-pushed the aleksandr-gringauz/RUM-12387/pass-ref-from-gradle-properties branch from 7d96d19 to 821b47a Compare January 2, 2026 10:44

aleksandr-gringauz mentioned this pull request Jan 2, 2026

RUM-12387: Add android sdk schema generator check DataDog/rum-events-format#334

Merged

aleksandr-gringauz commented Jan 2, 2026

View reviewed changes

aleksandr-gringauz marked this pull request as ready for review January 2, 2026 13:19

aleksandr-gringauz requested a review from a team as a code owner January 2, 2026 13:19

0xnm reviewed Jan 2, 2026

View reviewed changes

aleksandr-gringauz added 2 commits January 2, 2026 18:11

RUM-12387: Slight refactoring of RUM schema cloning and parser genera…

1d286d0

…tion tasks

RUM-12387: PR fixes

2f7ad91

aleksandr-gringauz force-pushed the aleksandr-gringauz/RUM-12387/pass-ref-from-gradle-properties branch from 7d13a96 to 2f7ad91 Compare January 2, 2026 17:11

RUM-12387: Add comment

ebd311a

aleksandr-gringauz force-pushed the aleksandr-gringauz/RUM-12387/pass-ref-from-gradle-properties branch from 060d9bb to ebd311a Compare January 2, 2026 17:29

aleksandr-gringauz requested a review from 0xnm January 2, 2026 17:30

0xnm approved these changes Jan 2, 2026

View reviewed changes

aleksandr-gringauz merged commit 17c117e into develop Jan 5, 2026
26 checks passed

aleksandr-gringauz deleted the aleksandr-gringauz/RUM-12387/pass-ref-from-gradle-properties branch January 5, 2026 10:02

	fun Project.createRumSchemaCloningTask(
	fun Project.createRumSchemaCloneTask(


		rootTask.dependsOn(task)

		tasks.withType(GenerateApiSurfaceTask::class.java).configureEach {

Uh oh!

Conversation

aleksandr-gringauz commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

Uh oh!

datadog-official Bot commented Jan 2, 2026 • edited by datadog-datadog-prod-us1 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aleksandr-gringauz commented Jan 2, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jan 2, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aleksandr-gringauz commented Jan 2, 2026 •

edited

Loading

datadog-official Bot commented Jan 2, 2026 •

edited by datadog-datadog-prod-us1 Bot

Loading

codecov-commenter commented Jan 2, 2026 •

edited

Loading