Skip to content

Expose Profiling start/stop as public API#3092

Merged
ambushwork merged 1 commit into
feature/perfetto-profilingfrom
yl/profiling/synthetics-build
Jan 5, 2026
Merged

Expose Profiling start/stop as public API#3092
ambushwork merged 1 commit into
feature/perfetto-profilingfrom
yl/profiling/synthetics-build

Conversation

@ambushwork

@ambushwork ambushwork commented Dec 31, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

This PR exposes start/stop profiling as public API, make it possible to send some custom profiling from sample app.
Note: this is not the final form of custom profiling.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork force-pushed the yl/profiling/synthetics-build branch 2 times, most recently from c153196 to 65ee30a Compare December 31, 2025 14:54
@ambushwork
ambushwork marked this pull request as ready for review December 31, 2025 14:54
@ambushwork
ambushwork requested a review from a team as a code owner December 31, 2025 14:54
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Dec 31, 2025
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread features/dd-sdk-android-profiling/src/main/java/com/datadog/android/profiling/Profiling.kt Outdated
@ambushwork
ambushwork force-pushed the yl/profiling/synthetics-build branch 3 times, most recently from f329a14 to 26d4bcd Compare January 2, 2026 07:33
@datadog-official

datadog-official Bot commented Jan 2, 2026 •
edited by datadog-datadog-prod-us1 Bot
Loading

Copy link
Copy Markdown

🎯 Code Coverage
• Patch Coverage: 62.50%
• Overall Coverage: 66.53% (-0.04%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f2628f1 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

0xnm
0xnm reviewed Jan 2, 2026
View reviewed changes
Comment thread features/dd-sdk-android-profiling/src/main/java/com/datadog/android/profiling/Profiling.kt Outdated
Comment thread features/dd-sdk-android-profiling/src/main/java/com/datadog/android/profiling/Profiling.kt Outdated
@codecov-commenter

codecov-commenter commented Jan 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.52%. Comparing base (ab2a008) to head (f2628f1).

Files with missing lines Patch % Lines
...in/java/com/datadog/android/profiling/Profiling.kt 50.00% 2 Missing ⚠️
...dog/android/profiling/internal/ProfilingFeature.kt 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@                     Coverage Diff                     @@
##           feature/perfetto-profiling    #3092   +/-   ##
===========================================================
  Coverage                       71.52%   71.52%           
===========================================================
  Files                             894      894           
  Lines                           32751    32755    +4     
  Branches                         5503     5503           
===========================================================
+ Hits                            23425    23428    +3     
+ Misses                           7781     7779    -2     
- Partials                         1545     1548    +3
Files with missing lines Coverage Δ
...dog/android/profiling/internal/ProfilingFeature.kt 69.57% <50.00%> (ø)
...in/java/com/datadog/android/profiling/Profiling.kt 56.25% <50.00%> (-0.89%) ⬇️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ambushwork
ambushwork force-pushed the yl/profiling/synthetics-build branch from 26d4bcd to d979b5b Compare January 2, 2026 08:31
@ambushwork
ambushwork requested a review from 0xnm January 2, 2026 10:39
0xnm
0xnm reviewed Jan 2, 2026
View reviewed changes
Comment thread features/dd-sdk-android-profiling/api/apiSurface Outdated
Comment thread features/dd-sdk-android-profiling/api/apiSurface Outdated
@ambushwork
ambushwork force-pushed the yl/profiling/synthetics-build branch 2 times, most recently from ef7ebe5 to adcebd4 Compare January 2, 2026 15:58
@ambushwork
ambushwork requested a review from 0xnm January 2, 2026 16:22
@ambushwork
ambushwork force-pushed the yl/profiling/synthetics-build branch from adcebd4 to 47b8acc Compare January 2, 2026 16:57
0xnm
0xnm requested changes Jan 5, 2026
View reviewed changes
Comment thread features/dd-sdk-android-profiling/src/main/java/com/datadog/android/profiling/Profiling.kt Outdated
Comment thread features/dd-sdk-android-profiling/src/main/java/com/datadog/android/profiling/Profiling.kt Outdated
}

/**
* Start profiling with given sdk instances names.

@0xnm 0xnm Jan 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Start profiling with given sdk instances names.
* Start profiling for a given SDK instance.

Comment thread features/dd-sdk-android-profiling/src/main/java/com/datadog/android/profiling/Profiling.kt Outdated
Comment thread features/dd-sdk-android-profiling/src/main/java/com/datadog/android/profiling/Profiling.kt Outdated
Comment thread features/dd-sdk-android-profiling/src/main/java/com/datadog/android/profiling/Profiling.kt Outdated
Comment thread sample/benchmark/transitiveDependencies
Comment thread sample/kotlin/src/main/kotlin/com/datadog/android/sample/profiling/ProfilingFragment.kt Outdated
Comment thread sample/kotlin/src/main/kotlin/com/datadog/android/sample/profiling/ProfilingFragment.kt Outdated
@ambushwork
ambushwork force-pushed the yl/profiling/synthetics-build branch from 47b8acc to d572d11 Compare January 5, 2026 10:52
@ambushwork ambushwork changed the title Expose Profiling start/stop as internal API Expose Profiling start/stop as public API Jan 5, 2026
@ambushwork
ambushwork force-pushed the yl/profiling/synthetics-build branch from d572d11 to 94051fc Compare January 5, 2026 10:55
@ambushwork
ambushwork requested a review from 0xnm January 5, 2026 10:56
0xnm
0xnm previously approved these changes Jan 5, 2026
View reviewed changes
Comment thread sample/kotlin/src/main/kotlin/com/datadog/android/sample/profiling/ProfilingFragment.kt Outdated
@ambushwork
ambushwork force-pushed the yl/profiling/synthetics-build branch from 94051fc to f2628f1 Compare January 5, 2026 13:35
@ambushwork
ambushwork merged commit 5cbded5 into feature/perfetto-profiling Jan 5, 2026
26 checks passed
@ambushwork
ambushwork deleted the yl/profiling/synthetics-build branch January 5, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@0xnm 0xnm 0xnm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ambushwork @codecov-commenter @0xnm