Skip to content

Generate Kotlin metadata ABI and JVM bytecode versions#3088

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/generate-compiled-files-abi-version
Dec 31, 2025
Merged

Generate Kotlin metadata ABI and JVM bytecode versions#3088
0xnm merged 1 commit into
developfrom
nogorodnikov/generate-compiled-files-abi-version

Conversation

@0xnm

@0xnm 0xnm commented Dec 30, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Kotlin adds metadata in a Metadata annotation of the generated Java class file and overall this metadata has version, making it incompatible for older compiler versions.

Read ABI changelog here https://github.com/JetBrains/kotlin/blob/master/compiler/util-klib/KotlinAbiVersionBumpHistory.md.

This PR adds a check to list ABI (metadata) version in the generated class files, so that we are aware about any breaking change -> this will force customers to use newer Kotlin version.

Plus JVM bytecode version is added as well.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm force-pushed the nogorodnikov/generate-compiled-files-abi-version branch from 7751e47 to d625aee Compare December 30, 2025 17:27
@0xnm
0xnm marked this pull request as ready for review December 30, 2025 17:27
@0xnm
0xnm requested a review from a team as a code owner December 30, 2025 17:27
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Dec 30, 2025

Copy link
Copy Markdown

🎯 Code Coverage
Patch Coverage: 100.00%
Overall Coverage: 66.47% (+0.07%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7f648b1 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter

codecov-commenter commented Dec 30, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.44%. Comparing base (714d915) to head (7f648b1).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3088      +/-   ##
===========================================
- Coverage    71.44%   71.44%   -0.00%     
===========================================
  Files          881      881              
  Lines        32397    32397              
  Branches      5462     5462              
===========================================
- Hits         23144    23143       -1     
+ Misses        7710     7704       -6     
- Partials      1543     1550       +7     

see 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm force-pushed the nogorodnikov/generate-compiled-files-abi-version branch from d625aee to 7f648b1 Compare December 31, 2025 08:34
@0xnm 0xnm changed the title Generate Kotlin metadata ABI version Generate Kotlin metadata ABI and JVM bytecode versions Dec 31, 2025
@0xnm
0xnm merged commit bcbe8d3 into develop Dec 31, 2025
26 of 27 checks passed
@0xnm
0xnm deleted the nogorodnikov/generate-compiled-files-abi-version branch December 31, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants