RUMS-5352 RUM-13527: Fix issue with OnWindowFocusChanged#3083
Merged
jonathanmos merged 1 commit intoDec 30, 2025
Conversation
jonathanmos
force-pushed
the
jmoskovich/rum-13527/fix-onwindowfocuschanged
branch
from
December 30, 2025 10:23
c87be23 to
08ea8b8
Compare
|
🎯 Code Coverage 🔗 Commit SHA: 08ea8b8 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3083 +/- ##
===========================================
+ Coverage 71.35% 71.38% +0.02%
===========================================
Files 881 881
Lines 32388 32389 +1
Branches 5462 5462
===========================================
+ Hits 23110 23118 +8
+ Misses 7732 7724 -8
- Partials 1546 1547 +1
🚀 New features to boost your workflow:
|
jonathanmos
marked this pull request as ready for review
December 30, 2025 12:53
aleksandr-gringauz
approved these changes
Dec 30, 2025
0xnm
approved these changes
Dec 30, 2025
jonathanmos
deleted the
jmoskovich/rum-13527/fix-onwindowfocuschanged
branch
December 30, 2025 13:07
allspain
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We were missing a call to the OnWindowFocusChanged callback in SR, and as a result were blocking this callback from returning.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)