RUM-13518: Fix Compose checkbox not sending RUM action#3077
Merged
Conversation
jonathanmos
changed the title
|
🎯 Code Coverage 🔗 Commit SHA: cc075ef | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3077 +/- ##
===========================================
+ Coverage 71.40% 71.46% +0.06%
===========================================
Files 881 881
Lines 32388 32388
Branches 5462 5462
===========================================
+ Hits 23126 23145 +19
+ Misses 7727 7698 -29
- Partials 1535 1545 +10
🚀 New features to boost your workflow:
|
jonathanmos
marked this pull request as ready for review
December 25, 2025 11:02
0xnm
previously approved these changes
Dec 26, 2025
Member
|
@codex review |
Member
|
LGTM! |
ambushwork
previously approved these changes
Dec 26, 2025
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
jonathanmos
force-pushed
the
jmoskovich/rum-13518/fix-checkbox-action
branch
from
December 28, 2025 09:05
25da177 to
cc075ef
Compare
0xnm
approved these changes
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
• Modifies
LayoutNodeUtilsto identify Compose checkboxes as clickable• Add stub classes for Compose elements to make tests more comprehensive
Motivation
Checkbox taps were not being sent as RUM actions.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)