Add ProfilingFragment into Sample Application#3074
Merged
Conversation
ambushwork
force-pushed
the
yl/add-profiling-sample
branch
from
December 23, 2025 13:29
dec0c66 to
01d1564
Compare
|
🎯 Code Coverage 🔗 Commit SHA: 86e1421 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/perfetto-profiling #3074 +/- ##
==============================================================
- Coverage 71.28% 71.27% -0.02%
==============================================================
Files 893 893
Lines 32689 32689
Branches 5493 5493
==============================================================
- Hits 23302 23296 -6
- Misses 7827 7833 +6
Partials 1560 1560 🚀 New features to boost your workflow:
|
ambushwork
marked this pull request as ready for review
December 23, 2025 14:16
0xnm
previously approved these changes
Dec 24, 2025
jonathanmos
previously approved these changes
Dec 24, 2025
ambushwork
force-pushed
the
yl/add-profiling-sample
branch
from
December 24, 2025 09:33
01d1564 to
5c8768c
Compare
0xnm
reviewed
Dec 24, 2025
ambushwork
force-pushed
the
yl/add-profiling-sample
branch
from
December 24, 2025 09:50
5c8768c to
86e1421
Compare
0xnm
approved these changes
Dec 24, 2025
jonathanmos
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a sample screen for custom profiling, currently not connected to Profiling feature since custom profiling API is not properly implemented yet, but we can use this screen in synthetics test for now.
Review checklist (to be filled by reviewers)