Skip to content

Add IDs to errors and long tasks#3073

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/add-ids-to-errors-long-tasks
Dec 23, 2025
Merged

Add IDs to errors and long tasks#3073
0xnm merged 1 commit into
developfrom
nogorodnikov/add-ids-to-errors-long-tasks

Conversation

@0xnm

@0xnm 0xnm commented Dec 22, 2025

Copy link
Copy Markdown
Member

What does this PR do?

IDs for errors and long tasks were added long time ago in DataDog/rum-events-format#34, but we never implemented this property.

This PR fixes that.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner December 22, 2025 17:57
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Dec 22, 2025

Copy link
Copy Markdown

🎯 Code Coverage
Patch Coverage: 100.00%
Overall Coverage: 66.35% (-0.01%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5931c42 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter

codecov-commenter commented Dec 22, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.29%. Comparing base (7606b1a) to head (5931c42).
⚠️ Report is 978 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3073      +/-   ##
===========================================
+ Coverage    71.28%   71.29%   +0.01%     
===========================================
  Files          880      880              
  Lines        32360    32364       +4     
  Branches      5457     5457              
===========================================
+ Hits         23066    23072       +6     
- Misses        7736     7752      +16     
+ Partials      1558     1540      -18     
Files with missing lines Coverage Δ
...g/android/rum/internal/DatadogLateCrashReporter.kt 86.46% <100.00%> (+0.59%) ⬆️
...roid/rum/internal/domain/scope/RumResourceScope.kt 90.70% <100.00%> (+0.61%) ⬆️
.../android/rum/internal/domain/scope/RumViewScope.kt 94.58% <100.00%> (+0.22%) ⬆️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ambushwork
ambushwork previously approved these changes Dec 23, 2025
jonathanmos
jonathanmos previously approved these changes Dec 23, 2025
@0xnm
0xnm dismissed stale reviews from jonathanmos and ambushwork via 5931c42 December 23, 2025 09:30
@0xnm
0xnm force-pushed the nogorodnikov/add-ids-to-errors-long-tasks branch from 4a92245 to 5931c42 Compare December 23, 2025 09:30
@0xnm
0xnm merged commit 875dfc8 into develop Dec 23, 2025
27 checks passed
@0xnm
0xnm deleted the nogorodnikov/add-ids-to-errors-long-tasks branch December 23, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants