Skip to content

Handle RumVitalAppLaunchEvent by default#3067

Merged
ambushwork merged 1 commit into
aleksandr-gringauz/feature/app-launch-vitalsfrom
yl/handle-vital-event-by-default
Dec 18, 2025
Merged

Handle RumVitalAppLaunchEvent by default#3067
ambushwork merged 1 commit into
aleksandr-gringauz/feature/app-launch-vitalsfrom
yl/handle-vital-event-by-default

Conversation

@ambushwork

@ambushwork ambushwork commented Dec 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Handle RumVitalAppLaunchEvent by default to stop throwing warning

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@datadog-official

datadog-official Bot commented Dec 18, 2025 •
edited
Loading

Copy link
Copy Markdown

🎯 Code Coverage
• Patch Coverage: 0.00%
• Overall Coverage: 66.35% (-5.24%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 99d59a7 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter

codecov-commenter commented Dec 18, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.60%. Comparing base (1c85511) to head (99d59a7).

Files with missing lines Patch % Lines
...ndroid/rum/internal/domain/event/RumEventMapper.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                               Coverage Diff                                @@
##           aleksandr-gringauz/feature/app-launch-vitals    #3067      +/-   ##
================================================================================
+ Coverage                                         71.35%   71.60%   +0.25%     
================================================================================
  Files                                               868      868              
  Lines                                             31960    31986      +26     
  Branches                                           5385     5388       +3     
================================================================================
+ Hits                                              22803    22902      +99     
+ Misses                                             7622     7577      -45     
+ Partials                                           1535     1507      -28
Files with missing lines Coverage Δ
...ndroid/rum/internal/domain/event/RumEventMapper.kt 98.33% <0.00%> (-1.67%) ⬇️

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ambushwork
ambushwork marked this pull request as ready for review December 18, 2025 13:25
@ambushwork
ambushwork requested a review from a team as a code owner December 18, 2025 13:25
0xnm
0xnm approved these changes Dec 18, 2025
View reviewed changes
Comment thread ...-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/event/RumEventMapper.kt
@ambushwork
ambushwork merged commit 548d04f into aleksandr-gringauz/feature/app-launch-vitals Dec 18, 2025
26 checks passed
@ambushwork
ambushwork deleted the yl/handle-vital-event-by-default branch December 18, 2025 14:04
@ncreated
ncreated restored the yl/handle-vital-event-by-default branch April 9, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
@aleksandr-gringauz aleksandr-gringauz aleksandr-gringauz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ambushwork @codecov-commenter @0xnm @aleksandr-gringauz