RUM-13441: Moving HttpSpec, RequestInfo/ResponseInfo into internal module#3064
Merged
Conversation
satween
changed the title
internalmoduleinternal module
aleksandr-gringauz
previously approved these changes
Dec 17, 2025
satween
force-pushed
the
tvaleev/feature/RUM-13441
branch
from
December 18, 2025 11:49
57ac666 to
e536a5a
Compare
0xnm
approved these changes
Dec 18, 2025
| * Headers used internally for intercepting GraphQL requests. | ||
| * @param headerValue name of the header. | ||
| */ | ||
| // TODO RUM-13454 - move these headers to [HttpSpec] |
Member
There was a problem hiding this comment.
they are not a part of HTTP spec though, it is just custom headers created by us to allow passing data between Apollo and OkHttp APIs, so they shouldn't go there
ambushwork
approved these changes
Dec 18, 2025
|
🎯 Code Coverage 🔗 Commit SHA: e536a5a | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3064 +/- ##
===========================================
- Coverage 71.22% 71.12% -0.10%
===========================================
Files 876 877 +1
Lines 32118 32126 +8
Branches 5429 5430 +1
===========================================
- Hits 22874 22848 -26
- Misses 7699 7731 +32
- Partials 1545 1547 +2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves common classes from
coretointernalmoduleReview checklist (to be filled by reviewers)