Skip to content

Rum Resources instrumentation support for Cronet network library.#3062

Merged
satween merged 14 commits into
developfrom
feature/cronet
Dec 17, 2025
Merged

Rum Resources instrumentation support for Cronet network library.#3062
satween merged 14 commits into
developfrom
feature/cronet

Conversation

@satween

@satween satween commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

This branch consist only from merge commits.
All of them already reviewed:

feature/cronet adds Cronet instrumentation support (RUM Resources only at the moment.)

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

satween and others added 13 commits November 11, 2025 00:22
@satween
RUM-12638: adding cronet lib integration module to the project
d6d5cc6
@satween
RUM-12638: adding sample app page for testing cronet integration
e10ec66
@satween
RUM-12638: review fixes
46b8c00
@satween
RUM-12638: Fix detekt
600a0a4
@satween
Merge pull request #2999 from DataDog/tvaleev/feature/RUM-12638-modul…
baeb6e7 
…e-for-cronet

[RUM-12638][Cronet]: Cronet integration module and sample app support
@satween
Merge remote-tracking branch 'origin/develop' into tvaleev/feature/RU…
f696c88 
…M-12633-merge-develop
@satween
Merge pull request #3028 from DataDog/tvaleev/feature/RUM-12633-merge…
0c156cc 
…-develop

RUM-12633: Merge `develop` into `cronet` feature branch
@satween
RUM-12635: Adding wrappers
a111d25
@satween
RUM-12635: post-review fixes
f600f1e
@satween
RUM-12635: Adding experimental annotation for cronet engine wrapper
0817c4d
@satween
RUM-12635: post-review fixes
c524465
@satween
Merge pull request #3029 from DataDog/tvaleev/feature/RUM-12635-wrapp…
1cb6abb 
…er-support

RUM-12635: RUM support for Cronet
@satween
Merge remote-tracking branch 'origin/develop' into tvaleev/feature/me…
8a33960 
…rge_dev_into_cronet

# Conflicts:
#	detekt_custom_safe_calls.yml
#	integrations/dd-sdk-android-okhttp/src/main/kotlin/com/datadog/android/okhttp/DatadogEventListener.kt
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Dec 17, 2025 •
edited
Loading

Copy link
Copy Markdown

🎯 Code Coverage
• Patch Coverage: 82.51%
• Overall Coverage: 71.50%

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0177dae | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter

codecov-commenter commented Dec 17, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 69.13580% with 125 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.22%. Comparing base (ed7f4e1) to head (0177dae).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...oid/rum/internal/net/RumResourceInstrumentation.kt 0.00% 80 Missing ⚠️
.../com/datadog/android/cronet/DatadogCronetEngine.kt 88.17% 11 Missing ⚠️
.../com/datadog/android/core/internal/net/HttpSpec.kt 0.00% 8 Missing ⚠️
...g/android/cronet/internal/CronetHttpRequestInfo.kt 73.33% 5 Missing and 3 partials ⚠️
...net/internal/DatadogRequestFinishedInfoListener.kt 89.09% 3 Missing and 3 partials ⚠️
.../android/okhttp/internal/OkHttpHttpResponseInfo.kt 90.62% 0 Missing and 3 partials ⚠️
...mResourceAttributesProviderCompatibilityAdapter.kt 81.25% 0 Missing and 3 partials ⚠️
.../android/cronet/internal/CronetHttpResponseInfo.kt 81.82% 0 Missing and 2 partials ⚠️
...ndroid/cronet/internal/DatadogUrlRequestBuilder.kt 95.83% 1 Missing and 1 partial ⚠️
...api/instrumentation/network/ExtendedRequestInfo.kt 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3062      +/-   ##
===========================================
- Coverage    71.24%   71.22%   -0.02%     
===========================================
  Files          866      876      +10     
  Lines        31730    32118     +388     
  Branches      5360     5429      +69     
===========================================
+ Hits         22604    22874     +270     
- Misses        7602     7706     +104     
- Partials      1524     1538      +14
Files with missing lines Coverage Δ
...tadog/android/cronet/internal/DatadogUrlRequest.kt 100.00% <100.00%> (ø)
...com/datadog/android/okhttp/DatadogEventListener.kt 96.15% <ø> (ø)
...n/com/datadog/android/okhttp/DatadogInterceptor.kt 73.66% <100.00%> (+0.58%) ⬆️
...g/android/okhttp/internal/OkHttpHttpRequestInfo.kt 100.00% <100.00%> (ø)
...api/instrumentation/network/ExtendedRequestInfo.kt 0.00% <0.00%> (ø)
...tadog/android/rum/RumResourceAttributesProvider.kt 0.00% <0.00%> (ø)
.../android/cronet/internal/CronetHttpResponseInfo.kt 81.82% <81.82%> (ø)
...ndroid/cronet/internal/DatadogUrlRequestBuilder.kt 95.83% <95.83%> (ø)
.../android/okhttp/internal/OkHttpHttpResponseInfo.kt 90.62% <90.62%> (ø)
...mResourceAttributesProviderCompatibilityAdapter.kt 81.25% <81.25%> (ø)
... and 5 more

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@satween
satween marked this pull request as ready for review December 17, 2025 14:00
@satween
satween requested review from a team as code owners December 17, 2025 14:00
0xnm
0xnm approved these changes Dec 17, 2025
View reviewed changes
Comment thread dd-sdk-android-core/src/main/kotlin/com/datadog/android/core/internal/net/HttpSpec.kt
* HTTP specification constants and utilities.
*/
@InternalApi
object HttpSpec {

@0xnm 0xnm Dec 17, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, since it doesn't have any dependency on the InternalLogger anymore, this can be moved to the -internal package, it doesn't need to be in the core

@satween satween Dec 17, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do this with next PR

@satween
satween merged commit eebab6b into develop Dec 17, 2025
25 of 26 checks passed
@satween
satween deleted the feature/cronet branch June 24, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@satween @codecov-commenter @0xnm