Skip to content

Remove JVM assert usage#3061

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/remove-jvm-assert
Dec 17, 2025
Merged

Remove JVM assert usage#3061
0xnm merged 1 commit into
developfrom
nogorodnikov/remove-jvm-assert

Conversation

@0xnm

@0xnm 0xnm commented Dec 17, 2025

Copy link
Copy Markdown
Member

What does this PR do?

There is JVM assert usage in the code, which is no-op only unless JVM if started with -ea (enable assertions) flag.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner December 17, 2025 11:51
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Dec 17, 2025

Copy link
Copy Markdown

🎯 Code Coverage
Patch Coverage: 100.00%
Overall Coverage: 76.72%

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4ac00c9 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.22%. Comparing base (ed7f4e1) to head (4ac00c9).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3061      +/-   ##
===========================================
- Coverage    71.24%   71.22%   -0.02%     
===========================================
  Files          866      866              
  Lines        31730    31730              
  Branches      5360     5361       +1     
===========================================
- Hits         22604    22599       -5     
- Misses        7602     7606       +4     
- Partials      1524     1525       +1     

see 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm merged commit 3f25b26 into develop Dec 17, 2025
27 of 28 checks passed
@0xnm
0xnm deleted the nogorodnikov/remove-jvm-assert branch December 17, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants