Fix null build id in profile event tags#3059
Merged
ambushwork merged 1 commit intoDec 17, 2025
Merged
Conversation
0xnm
approved these changes
Dec 17, 2025
|
🎯 Code Coverage 🔗 Commit SHA: 4689800 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/perfetto-profiling #3059 +/- ##
==============================================================
+ Coverage 71.39% 71.41% +0.03%
==============================================================
Files 881 881
Lines 32288 32289 +1
Branches 5420 5421 +1
==============================================================
+ Hits 23049 23058 +9
+ Misses 7701 7692 -9
- Partials 1538 1539 +1
🚀 New features to boost your workflow:
|
ambushwork
merged commit Dec 17, 2025
0f31429
into
feature/perfetto-profiling
26 of 28 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix the issue that we still add build id in the tag when the build id is null, (finally it showed like
build_id:nullin the frontend)Unit test already covers it with a nullable forgery string.
Review checklist (to be filled by reviewers)