Skip to content

RUM-10163: Add Coil3 Integration#3054

Merged
jonathanmos merged 2 commits into
developfrom
jmoskovich/rum-10163/coil3-support
Dec 23, 2025
Merged

RUM-10163: Add Coil3 Integration#3054
jonathanmos merged 2 commits into
developfrom
jmoskovich/rum-10163/coil3-support

Conversation

@jonathanmos

Copy link
Copy Markdown
Member

What does this PR do?

Adds an integration for Coil3. This has the following main components:

• New module for Coil3.
• DatadogCoilRequestListener captures relevant information from errors.
• Changes to the sampleApplication for Coil3 support

Motivation

Add Coil3 support.

Additional Notes

Coil version that was added is 3.0.4. The version couldn't be higher, because higher Coil versions require a higher version of Kotlin than what we currently use.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@jonathanmos
jonathanmos force-pushed the jmoskovich/rum-10163/coil3-support branch 2 times, most recently from 128d88b to 32dd4f8 Compare December 15, 2025 14:51
@datadog-official

datadog-official Bot commented Dec 15, 2025

Copy link
Copy Markdown

🎯 Code Coverage
Patch Coverage: 100.00%
Overall Coverage: 66.39% (+0.05%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 207e756 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter

codecov-commenter commented Dec 15, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.32%. Comparing base (3e289ad) to head (207e756).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...onreplay/compose/internal/utils/ReflectionUtils.kt 0.00% 3 Missing ⚠️
...y/compose/internal/reflection/ComposeReflection.kt 0.00% 2 Missing ⚠️
...atadog/android/coil3/DatadogCoilRequestListener.kt 95.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3054      +/-   ##
===========================================
- Coverage    71.33%   71.32%   -0.01%     
===========================================
  Files          880      881       +1     
  Lines        32360    32376      +16     
  Branches      5457     5462       +5     
===========================================
+ Hits         23082    23090       +8     
- Misses        7742     7748       +6     
- Partials      1536     1538       +2     
Files with missing lines Coverage Δ
...atadog/android/coil3/DatadogCoilRequestListener.kt 95.00% <95.00%> (ø)
...y/compose/internal/reflection/ComposeReflection.kt 0.00% <0.00%> (ø)
...onreplay/compose/internal/utils/ReflectionUtils.kt 1.27% <0.00%> (+0.05%) ⬆️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonathanmos
jonathanmos force-pushed the jmoskovich/rum-10163/coil3-support branch from 32dd4f8 to 451e53c Compare December 22, 2025 09:21
@jonathanmos
jonathanmos marked this pull request as ready for review December 22, 2025 11:47
@jonathanmos
jonathanmos requested review from a team as code owners December 22, 2025 11:47

@0xnm 0xnm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! we also need to add this module to the CI setup, local_ci.sh, CONTRIBUTING.md. Do you want to do this in the same PR?

hestonhoffman
hestonhoffman previously approved these changes Dec 22, 2025
ambushwork
ambushwork previously approved these changes Dec 22, 2025
@jonathanmos
jonathanmos dismissed stale reviews from ambushwork and hestonhoffman via 207e756 December 23, 2025 09:19
@jonathanmos
jonathanmos merged commit 5a0ff29 into develop Dec 23, 2025
26 of 28 checks passed
@jonathanmos
jonathanmos deleted the jmoskovich/rum-10163/coil3-support branch December 23, 2025 10:15
@0xnm 0xnm mentioned this pull request Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants