RUM-12069: Fix service handling in ddtags of LogEvent#3052
Merged
Conversation
|
🎯 Code Coverage * Fix with Cursor requires Datadog plugin ≥v2.17.0 🔗 Commit SHA: 21527b5 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
ambushwork
previously approved these changes
Dec 12, 2025
satween
self-requested a review
December 12, 2025 10:31
satween
previously approved these changes
Dec 12, 2025
0xnm
force-pushed
the
nogorodnikov/rum-12069/fix-service-in-logs-ddtags
branch
from
December 12, 2025 10:31
b7110a1 to
21527b5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3052 +/- ##
===========================================
- Coverage 71.24% 71.22% -0.02%
===========================================
Files 866 866
Lines 31730 31726 -4
Branches 5360 5360
===========================================
- Hits 22604 22595 -9
- Misses 7602 7609 +7
+ Partials 1524 1522 -2
🚀 New features to boost your workflow:
|
ambushwork
approved these changes
Dec 12, 2025
|
Could we get a patch release with this fix? It's creating a lot of noise in our logs. |
Member
Author
|
This change doesn't qualify for the patch release: it is not affecting stability of the app and SDK logging can be disabled (this is what should be done in release builds anyway). We will have rather a minor release out either the next week or a week after. |
|
Yeah we're not logging in production. But it makes development very annoying since 90% of our logcat logs is this warning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up for #3006
Apparently
serviceinddtagswas dropped due to the following legacy verificationdd-sdk-android/dd-sdk-android-core/src/main/kotlin/com/datadog/android/core/constraints/DatadogDataConstraints.kt
Line 163 in ed7f4e1
It was added before reserved tags were added by the SDK, and didn't account for
variant,version,envtags we add, but hitservicetag.And since
ddtagsdon't show up in the Log event attributes in UI andserviceexists also in attributes, the only way to spot this was in the Logcat.This was also missed due to the missing test coverage in
single-fit/logs, so this PR adds the necessary assertions and also the logic to drop user-provided tags if they clash with what SDK adds.Review checklist (to be filled by reviewers)