Add Profiling.profileNextAppStartup API#3045
Merged
ambushwork merged 1 commit intoDec 11, 2025
Merged
Conversation
ambushwork
force-pushed
the
yl/profiling/add-next-launch-api
branch
from
December 10, 2025 10:49
5ab79a4 to
17cbdd6
Compare
|
🎯 Code Coverage 🔗 Commit SHA: 5f9b353 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
ambushwork
force-pushed
the
yl/profiling/add-next-launch-api
branch
from
December 10, 2025 12:33
17cbdd6 to
0967948
Compare
ambushwork
marked this pull request as ready for review
December 10, 2025 12:43
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/perfetto-profiling #3045 +/- ##
==============================================================
- Coverage 71.31% 71.27% -0.03%
==============================================================
Files 874 874
Lines 32006 32009 +3
Branches 5362 5364 +2
==============================================================
- Hits 22823 22814 -9
- Misses 7662 7663 +1
- Partials 1521 1532 +11
🚀 New features to boost your workflow:
|
0xnm
previously approved these changes
Dec 10, 2025
ambushwork
force-pushed
the
yl/profiling/add-next-launch-api
branch
from
December 10, 2025 14:53
0967948 to
5f9b353
Compare
0xnm
approved these changes
Dec 10, 2025
ambushwork
merged commit Dec 11, 2025
0342fdd
into
feature/perfetto-profiling
26 of 27 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Profiling.enableneeds to be called ASAP during the app startup, but the decision of profiling next app launch can usually be determined later with user's feature flags for example, so we need to add a dedicated API to control this.Review checklist (to be filled by reviewers)