Skip to content

Add Profiling.profileNextAppStartup API#3045

Merged
ambushwork merged 1 commit into
feature/perfetto-profilingfrom
yl/profiling/add-next-launch-api
Dec 11, 2025
Merged

Add Profiling.profileNextAppStartup API#3045
ambushwork merged 1 commit into
feature/perfetto-profilingfrom
yl/profiling/add-next-launch-api

Conversation

@ambushwork

Copy link
Copy Markdown
Member

What does this PR do?

Profiling.enable needs to be called ASAP during the app startup, but the decision of profiling next app launch can usually be determined later with user's feature flags for example, so we need to add a dedicated API to control this.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork force-pushed the yl/profiling/add-next-launch-api branch from 5ab79a4 to 17cbdd6 Compare December 10, 2025 10:49
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Dec 10, 2025

Copy link
Copy Markdown

🎯 Code Coverage
Patch Coverage: 31.58%
Total Coverage: 71.48% (+0.01%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5f9b353 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@ambushwork
ambushwork force-pushed the yl/profiling/add-next-launch-api branch from 17cbdd6 to 0967948 Compare December 10, 2025 12:33
@ambushwork
ambushwork marked this pull request as ready for review December 10, 2025 12:43
@ambushwork
ambushwork requested a review from a team as a code owner December 10, 2025 12:43
@codecov-commenter

codecov-commenter commented Dec 10, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.27%. Comparing base (8f39653) to head (5f9b353).
⚠️ Report is 6 commits behind head on feature/perfetto-profiling.

Files with missing lines Patch % Lines
...in/java/com/datadog/android/profiling/Profiling.kt 0.00% 10 Missing ⚠️
...dog/android/profiling/internal/ProfilingFeature.kt 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##           feature/perfetto-profiling    #3045      +/-   ##
==============================================================
- Coverage                       71.31%   71.27%   -0.03%     
==============================================================
  Files                             874      874              
  Lines                           32006    32009       +3     
  Branches                         5362     5364       +2     
==============================================================
- Hits                            22823    22814       -9     
- Misses                           7662     7663       +1     
- Partials                         1521     1532      +11     
Files with missing lines Coverage Δ
...dog/android/profiling/internal/ProfilingStorage.kt 100.00% <ø> (ø)
...dog/android/profiling/internal/ProfilingFeature.kt 69.57% <80.00%> (+0.52%) ⬆️
...in/java/com/datadog/android/profiling/Profiling.kt 0.00% <0.00%> (ø)

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

0xnm
0xnm previously approved these changes Dec 10, 2025
Comment thread features/dd-sdk-android-profiling/api/apiSurface
@ambushwork
ambushwork merged commit 0342fdd into feature/perfetto-profiling Dec 11, 2025
26 of 27 checks passed
@ambushwork
ambushwork deleted the yl/profiling/add-next-launch-api branch December 11, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants