Skip to content

Fix RUM context bundling for ProfileEvent#3036

Merged
0xnm merged 1 commit into
feature/perfetto-profilingfrom
nogorodnikov/fix-rum-context-bundling-for-profile-event
Dec 3, 2025
Merged

Fix RUM context bundling for ProfileEvent#3036
0xnm merged 1 commit into
feature/perfetto-profilingfrom
nogorodnikov/fix-rum-context-bundling-for-profile-event

Conversation

@0xnm

@0xnm 0xnm commented Dec 3, 2025

Copy link
Copy Markdown
Member

What does this PR do?

RUM context should be added as event attributes, not as tags.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners December 3, 2025 09:10
@0xnm
0xnm force-pushed the nogorodnikov/fix-rum-context-bundling-for-profile-event branch from 4d5c98d to 2f20949 Compare December 3, 2025 09:20
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Dec 3, 2025

Copy link
Copy Markdown

🎯 Code Coverage
Patch Coverage: 72.73%
Total Coverage: 71.51% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2f20949 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.33%. Comparing base (8f39653) to head (2f20949).

Files with missing lines Patch % Lines
.../android/profiling/internal/ProfilingDataWriter.kt 63.64% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##           feature/perfetto-profiling    #3036      +/-   ##
==============================================================
+ Coverage                       71.31%   71.33%   +0.02%     
==============================================================
  Files                             874      874              
  Lines                           32006    31995      -11     
  Branches                         5362     5359       -3     
==============================================================
- Hits                            22823    22822       -1     
+ Misses                           7662     7649      -13     
- Partials                         1521     1524       +3     
Files with missing lines Coverage Δ
.../android/profiling/internal/ProfilingDataWriter.kt 90.74% <63.64%> (-4.00%) ⬇️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm merged commit d2a3aee into feature/perfetto-profiling Dec 3, 2025
26 of 27 checks passed
@0xnm
0xnm deleted the nogorodnikov/fix-rum-context-bundling-for-profile-event branch December 3, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants