RUM-12635: RUM support for Cronet by satween · Pull Request #3029 · DataDog/dd-sdk-android

satween · 2025-11-27T10:53:50Z

What does this PR do?

This is a draft PR. work in progress

Adds instrumentation for the Crontet library.
Currently, only RUM Resources are supported (see the RFC in the JIRA ticket).
The common code base aimed to be shared between OkHttp and Cronet has been moved into RumResourceInstrumentation, but neither DatadogInterceptor nor TracingInterceptor are using it.
The instrumentation is added as a wrapper on top of the Cronet API that allows customer to use several instrumentation libraries at the same time.

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Make sure you discussed the feature or bugfix with the maintaining team in an Issue
Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

datadog-datadog-prod-us1 · 2025-11-27T14:15:39Z

🎯 Code Coverage
• Patch Coverage: 70.07%
• Overall Coverage: 71.36% (+0.01%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: c524465 | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

codecov-commenter · 2025-11-27T15:47:56Z

Codecov Report

❌ Patch coverage is 68.88889% with 126 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.15%. Comparing base (0c156cc) to head (c524465).
⚠️ Report is 64 commits behind head on feature/cronet.

Files with missing lines	Patch %	Lines
...oid/rum/internal/net/RumResourceInstrumentation.kt	0.00%	80 Missing ⚠️
.../com/datadog/android/cronet/DatadogCronetEngine.kt	88.17%	11 Missing ⚠️
.../com/datadog/android/core/internal/net/HttpSpec.kt	0.00%	8 Missing ⚠️
...g/android/cronet/internal/CronetHttpRequestInfo.kt	73.33%	5 Missing and 3 partials ⚠️
...net/internal/DatadogRequestFinishedInfoListener.kt	87.27%	3 Missing and 4 partials ⚠️
.../android/okhttp/internal/OkHttpHttpResponseInfo.kt	90.62%	0 Missing and 3 partials ⚠️
...mResourceAttributesProviderCompatibilityAdapter.kt	81.25%	0 Missing and 3 partials ⚠️
.../android/cronet/internal/CronetHttpResponseInfo.kt	81.82%	0 Missing and 2 partials ⚠️
...ndroid/cronet/internal/DatadogUrlRequestBuilder.kt	95.83%	1 Missing and 1 partial ⚠️
...api/instrumentation/network/ExtendedRequestInfo.kt	0.00%	1 Missing ⚠️
... and 1 more

Additional details and impacted files

@@                Coverage Diff                 @@
##           feature/cronet    #3029      +/-   ##
==================================================
- Coverage           71.22%   71.15%   -0.07%     
==================================================
  Files                 859      869      +10     
  Lines               31457    31844     +387     
  Branches             5306     5374      +68     
==================================================
+ Hits                22405    22658     +253     
- Misses               7544     7668     +124     
- Partials             1508     1518      +10

Files with missing lines	Coverage Δ
...tadog/android/cronet/internal/DatadogUrlRequest.kt	`100.00% <100.00%> (ø)`
...com/datadog/android/okhttp/DatadogEventListener.kt	`96.15% <ø> (ø)`
...n/com/datadog/android/okhttp/DatadogInterceptor.kt	`74.59% <100.00%> (+0.57%)`	⬆️
...g/android/okhttp/internal/OkHttpHttpRequestInfo.kt	`100.00% <100.00%> (ø)`
...api/instrumentation/network/ExtendedRequestInfo.kt	`0.00% <0.00%> (ø)`
...tadog/android/rum/RumResourceAttributesProvider.kt	`0.00% <0.00%> (ø)`
.../android/cronet/internal/CronetHttpResponseInfo.kt	`81.82% <81.82%> (ø)`
...ndroid/cronet/internal/DatadogUrlRequestBuilder.kt	`95.83% <95.83%> (ø)`
.../android/okhttp/internal/OkHttpHttpResponseInfo.kt	`90.62% <90.62%> (ø)`
...mResourceAttributesProviderCompatibilityAdapter.kt	`81.25% <81.25%> (ø)`
... and 5 more

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ambushwork

Just finish the review of the half, will continue on next week.

0xnm

I went only through the production files so far, didn't cover tests

0xnm

🚀

I managed to review production files, the only blocking comments are about public API, the rest are minor/nits.

I will try to cover tests asap later.

0xnm

I reviewed the remaining files.

drichards-87

Left a couple of minor suggestions from Docs and approved the PR.

0xnm

🚀

satween changed the title ~~RUM-12635: RUM support for Cronet~~ [WIP] RUM-12635: RUM support for Cronet Nov 27, 2025

satween force-pushed the tvaleev/feature/RUM-12635-wrapper-support branch from 0a842f7 to ec8f689 Compare November 27, 2025 13:51

RUM-12635: Adding wrappers

a111d25

satween force-pushed the tvaleev/feature/RUM-12635-wrapper-support branch from ec8f689 to a111d25 Compare November 28, 2025 10:09

satween changed the title ~~[WIP] RUM-12635: RUM support for Cronet~~ RUM-12635: RUM support for Cronet Nov 28, 2025

satween marked this pull request as ready for review November 28, 2025 10:10

satween requested review from a team as code owners November 28, 2025 10:10

ambushwork requested changes Nov 28, 2025

View reviewed changes

0xnm reviewed Dec 1, 2025

View reviewed changes

ambushwork reviewed Dec 1, 2025

View reviewed changes

jonathanmos reviewed Dec 2, 2025

View reviewed changes

Comment thread ...android-okhttp/src/main/kotlin/com/datadog/android/okhttp/internal/OkHttpHttpResponseInfo.kt

Comment thread ...et/src/main/kotlin/com/datadog/android/cronet/internal/DatadogRequestFinishedInfoListener.kt

jonathanmos reviewed Dec 2, 2025

View reviewed changes

Comment thread ...android-okhttp/src/test/kotlin/com/datadog/android/okhttp/DatadogEventListenerFactoryTest.kt Outdated

RUM-12635: post-review fixes

f600f1e

satween requested review from 0xnm, ambushwork and jonathanmos December 10, 2025 14:28

RUM-12635: Adding experimental annotation for cronet engine wrapper

0817c4d

0xnm reviewed Dec 11, 2025

View reviewed changes

satween force-pushed the tvaleev/feature/RUM-12635-wrapper-support branch from aa76518 to ecb5350 Compare December 12, 2025 15:12

satween requested a review from 0xnm December 12, 2025 15:14

ambushwork previously approved these changes Dec 15, 2025

View reviewed changes

Comment thread ...-core/src/main/kotlin/com/datadog/android/api/instrumentation/network/ExtendedRequestInfo.kt Outdated

Comment thread ...ions/dd-sdk-android-cronet/src/main/kotlin/com/datadog/android/cronet/DatadogCronetEngine.kt Outdated

Comment thread detekt_custom_safe_calls.yml

satween dismissed ambushwork’s stale review via c3fd6ee December 15, 2025 16:34

satween force-pushed the tvaleev/feature/RUM-12635-wrapper-support branch from ecb5350 to c3fd6ee Compare December 15, 2025 16:34

satween requested a review from ambushwork December 15, 2025 16:34

ambushwork previously approved these changes Dec 15, 2025

View reviewed changes

satween dismissed ambushwork’s stale review via 1010c59 December 15, 2025 18:07

0xnm reviewed Dec 15, 2025

View reviewed changes

0xnm reviewed Dec 16, 2025

View reviewed changes

satween requested a review from a team as a code owner December 16, 2025 16:19

satween force-pushed the tvaleev/feature/RUM-12635-wrapper-support branch from 35628c4 to d479677 Compare December 16, 2025 16:21

satween requested a review from 0xnm December 16, 2025 16:22

drichards-87 previously approved these changes Dec 16, 2025

View reviewed changes

Comment thread integrations/dd-sdk-android-cronet/README.md Outdated

Comment thread integrations/dd-sdk-android-cronet/README.md Outdated

0xnm previously approved these changes Dec 17, 2025

View reviewed changes

satween dismissed stale reviews from 0xnm and drichards-87 via c7b786c December 17, 2025 10:52

satween force-pushed the tvaleev/feature/RUM-12635-wrapper-support branch from d479677 to c7b786c Compare December 17, 2025 10:52

0xnm previously approved these changes Dec 17, 2025

View reviewed changes

Comment thread integrations/dd-sdk-android-cronet/README.md Outdated

RUM-12635: post-review fixes

c524465

satween dismissed 0xnm’s stale review via c524465 December 17, 2025 11:06

satween force-pushed the tvaleev/feature/RUM-12635-wrapper-support branch from c7b786c to c524465 Compare December 17, 2025 11:06

0xnm approved these changes Dec 17, 2025

View reviewed changes

satween merged commit 1cb6abb into feature/cronet Dec 17, 2025
26 checks passed

satween deleted the tvaleev/feature/RUM-12635-wrapper-support branch December 17, 2025 12:10

satween mentioned this pull request Dec 17, 2025

Rum Resources instrumentation support for Cronet network library. #3062

Merged

3 tasks

0xnm restored the tvaleev/feature/RUM-12635-wrapper-support branch March 26, 2026 10:41

Uh oh!

Conversation

satween commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Review checklist (to be filled by reviewers)

Uh oh!

datadog-datadog-prod-us1 Bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ambushwork left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

0xnm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

0xnm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

0xnm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

drichards-87 left a comment

Choose a reason for hiding this comment

Uh oh!

satween commented Nov 27, 2025 •

edited

Loading

datadog-datadog-prod-us1 Bot commented Nov 27, 2025 •

edited

Loading

codecov-commenter commented Nov 27, 2025 •

edited

Loading