RUM-12633: Merge `develop` into `cronet` feature branch by satween · Pull Request #3028 · DataDog/dd-sdk-android

satween · 2025-11-26T16:31:54Z

What does this PR do?

Merges develop into cronet feature branch.

Motivation

Required to fix broken detekt rules by flags feature.

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Make sure you discussed the feature or bugfix with the maintaining team in an Issue
Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

…es for the OkHttp integration

fix: Detekt violations in the flags module Co-authored-by: typotter <[email protected]>

RUM-12720: Updating MIGRATION.MD with the default sampling rate

refs: RUM-12763 This PR adds a check to RUM feature initialization: if the new internal option `_dd.rum.disable_jank_stats` is explicitly set to true, then we refrain from calling `initializeFrameStatesAggregator()`. Otherwise, we call that function as normal. This allows the Unity SDK to configure the Android SDK in such a way that it will never call `JankStats.createAndTrack()`, which is necessary to avoid crashes caused by the older versions of `androidx.metrics` that the `dd-sdk-unity` is forced to use in older versions of Unity. (I notice that the generated `apiSurface` files are not up to date at latest in develop, so I expect that CI will fail. When I test locally with `./local-ci.sh --test`, everything passes. I can rebase once the unrelated API surface issue is fixed in develop.)

…k-stats fix: Add internal disableJankStats config option

RUM-7562: Provide SDK commit SHA1 to the Shopist App

…ample-rate

…mentation-tests-behavioral RUM-5445: Revive Session Replay instrumentation tests

…elemetry-sample-rate RUM-5387: Override Metrics telemetry sample rate

…ception

…al-exception RUM-10417: Handle potential StackOverflowError

…M-12633-merge-develop

datadog-official · 2025-11-26T16:48:41Z

🎯 Code Coverage
• Patch Coverage: 94.23%
• Total Coverage: 71.35% (+0.08%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: f696c88 | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

codecov-commenter · 2025-11-26T17:00:38Z

Codecov Report

❌ Patch coverage is 83.91960% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.23%. Comparing base (baeb6e7) to head (f696c88).

Files with missing lines	Patch %	Lines
...ionreplay/compose/internal/utils/SemanticsUtils.kt	77.78%	6 Missing and 8 partials ⚠️
...id/webview/internal/log/WebViewLogEventConsumer.kt	82.61%	2 Missing and 2 partials ⚠️
...kotlin/com/datadog/android/rum/RumConfiguration.kt	0.00%	2 Missing ⚠️
.../main/kotlin/com/datadog/android/_InternalProxy.kt	0.00%	0 Missing and 1 partial ⚠️
...n/com/datadog/android/core/internal/CoreFeature.kt	85.71%	1 Missing ⚠️
...tadog/android/core/internal/NoOpContextProvider.kt	0.00%	1 Missing ⚠️
.../android/core/internal/logger/SdkInternalLogger.kt	83.33%	0 Missing and 1 partial ⚠️
...oid/core/internal/system/NoOpAppVersionProvider.kt	0.00%	1 Missing ⚠️
...tadog/android/flags/internal/FlagValueConverter.kt	50.00%	0 Missing and 1 partial ⚠️
...otlin/com/datadog/android/rum/_RumInternalProxy.kt	0.00%	1 Missing ⚠️
... and 5 more

Additional details and impacted files

@@                Coverage Diff                 @@
##           feature/cronet    #3028      +/-   ##
==================================================
+ Coverage           71.13%   71.23%   +0.11%     
==================================================
  Files                 859      859              
  Lines               31308    31457     +149     
  Branches             5275     5306      +31     
==================================================
+ Hits                22268    22408     +140     
- Misses               7547     7550       +3     
- Partials             1493     1499       +6

Files with missing lines	Coverage Δ
.../com/datadog/android/api/context/DatadogContext.kt	`100.00% <100.00%> (ø)`
...og/android/core/internal/DatadogContextProvider.kt	`98.15% <100.00%> (+0.03%)`	⬆️
.../core/internal/system/DefaultAppVersionProvider.kt	`100.00% <100.00%> (ø)`
...g/android/core/internal/time/KronosTimeProvider.kt	`100.00% <100.00%> (ø)`
...com/datadog/android/flags/internal/FlagsFeature.kt	`83.08% <ø> (ø)`
...s/internal/net/PrecomputedAssignmentsDownloader.kt	`100.00% <ø> (ø)`
...ternal/net/PrecomputedAssignmentsRequestFactory.kt	`70.91% <ø> (ø)`
...lags/internal/repository/DefaultFlagsRepository.kt	`65.31% <ø> (ø)`
...android/log/internal/domain/DatadogLogGenerator.kt	`97.99% <100.00%> (+0.07%)`	⬆️
...ndroid/rum/internal/domain/scope/RumActionScope.kt	`96.53% <100.00%> (+0.03%)`	⬆️
... and 25 more

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jonathanmos and others added 30 commits October 22, 2025 16:15

Refactor the instrumental tests into behavioral tests

8cd706d

Touch privacy

97b021c

Text and input privacy

c61454a

Cleanup json testing remnants

b3ee923

Fix legacy tests to be behavioral

f0b25fb

PANA-4799: Regenerate schema models

41dd7fa

PANA-4799: Fix sample application screens to respect system windows

c9d5c94

PANA-4799: Support text truncation for native

5c7738f

PANA-4799: Support text truncation for compose

8153514

RUM-7562: Include git commit sha1 inside the publishing config

18207bb

add flags custom detekt rules

fbd3270

also clean flags in local ci

ddfb15e

RUM-7562: Change solution to core's BuildConfig file

4233bcf

safe calls

706f0f1

Detekt complaints

1b992f0

RUM-12720: Updating MIGRATION.MD with the default sampling rate updat…

229838d

…es for the OkHttp integration

supress verified calls

37a19a9

insert forEach in order

429ad4b

Merge pull request #2994 from DataDog/typo/detekt-errors

d3c4acb

fix: Detekt violations in the flags module Co-authored-by: typotter <[email protected]>

Merge pull request #2995 from DataDog/tvaleev/feature/RUM-12720

d96dcda

RUM-12720: Updating MIGRATION.MD with the default sampling rate

Merge branch 'develop' into kikoveiga/RUM-7562/sha1-snapshot

3918198

RUM-5445: Temporarily remove checkbox tests

e0e0a15

RUM-5445: Refactor to make easier to maintain

7145153

fix: Add internal disableJankStats field, don't use additionalConfig

2b8d4f9

chore: Fix forgery init, commit generated apiSurface changes

63c16f0

Merge pull request #3000 from DataDog/aforsythe/RUM-12763/disable-jan…

795feec

…k-stats fix: Add internal disableJankStats config option

Merge pull request #2993 from DataDog/kikoveiga/RUM-7562/sha1-snapshot

bc35e34

RUM-7562: Provide SDK commit SHA1 to the Shopist App

Fix RumWindowCallbacksRegistry for multiple SDK instances

b5ac016

PANA-4799: Compose text truncation tests to parameterized

65f37dd

kikoveiga and others added 22 commits November 21, 2025 14:03

Merge branch 'develop' into kikoveiga/RUM-5387/set-metric-telemetry-s…

9f860da

…ample-rate

RUM-5387: Change place of metricTelemetrySampleRateBypass

e303b04

RUM-5387: Change place of metricTelemetrySampleRateBypass

787dc31

RUM-5387: Small improvements

f5c2f62

Merge pull request #2965 from DataDog/jmoskovich/rum-5445/make-instru…

cf41629

…mentation-tests-behavioral RUM-5445: Revive Session Replay instrumentation tests

RUM-5387: Remove code from SampleApplication.kt

6c9d4ad

RUM-5387: Small suggested improvements

a412359

Merge pull request #3022 from DataDog/kikoveiga/RUM-5387/set-metric-t…

8f7122f

…elemetry-sample-rate RUM-5387: Override Metrics telemetry sample rate

RUM-10417: Implement solution

7daeeba

RUM-10417: Small improvement

914cf24

RUM-12062: Rollback and add a try catch to handle the StackOverflowEx…

5d57871

…ception

Update detekt_custom_safe_calls.yml

7d8ea6d

RUM-12062: Add a test to check StackOverflowError

9275cda

RUM-12062: Simplify request key

4e85c67

RUM-12062: Improve structure of the error handling

eba7eac

RUM-10417: Remove unnecessary api code

14709a8

RUM-10417: Update statusCode max forge value

37de7d3

RUM-10417: Rethrow the exception

cf2c6c0

RUM-10417: Add Suppress call

a08f258

RUM-10417: Fix the unit test

ff8e241

Merge pull request #2990 from DataDog/kikoveiga/RUM-10417/fix-potenti…

9794bcb

…al-exception RUM-10417: Handle potential StackOverflowError

Merge remote-tracking branch 'origin/develop' into tvaleev/feature/RU…

f696c88

…M-12633-merge-develop

satween requested review from a team as code owners November 26, 2025 16:31

0xnm approved these changes Nov 26, 2025

View reviewed changes

satween merged commit 0c156cc into feature/cronet Nov 26, 2025
26 checks passed

satween deleted the tvaleev/feature/RUM-12633-merge-develop branch November 26, 2025 17:51

satween mentioned this pull request Dec 17, 2025

Rum Resources instrumentation support for Cronet network library. #3062

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

RUM-12633: Merge `develop` into `cronet` feature branch#3028

RUM-12633: Merge `develop` into `cronet` feature branch#3028
satween merged 99 commits into
feature/cronetfrom
tvaleev/feature/RUM-12633-merge-develop

satween commented Nov 26, 2025

Uh oh!

datadog-official Bot commented Nov 26, 2025 •

edited

Loading

Uh oh!

codecov-commenter commented Nov 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

satween commented Nov 26, 2025

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

Uh oh!

datadog-official Bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Nov 26, 2025

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

datadog-official Bot commented Nov 26, 2025 •

edited

Loading