Skip to content

RUM-12955: Add profiling status in RUM vital event#3021

Merged
ambushwork merged 1 commit into
feature/perfetto-profilingfrom
yl/profiling/add-profiling-vital
Nov 24, 2025
Merged

RUM-12955: Add profiling status in RUM vital event#3021
ambushwork merged 1 commit into
feature/perfetto-profilingfrom
yl/profiling/add-profiling-vital

Conversation

@ambushwork

Copy link
Copy Markdown
Member

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter

codecov-commenter commented Nov 21, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.16%. Comparing base (ab1e3f9) to head (6fbff03).

Files with missing lines Patch % Lines
...dog/android/profiling/internal/ProfilingFeature.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##           feature/perfetto-profiling    #3021      +/-   ##
==============================================================
- Coverage                       71.21%   71.16%   -0.05%     
==============================================================
  Files                             874      874              
  Lines                           31801    31814      +13     
  Branches                         5324     5326       +2     
==============================================================
- Hits                            22646    22639       -7     
- Misses                           7644     7661      +17     
- Partials                         1511     1514       +3     
Files with missing lines Coverage Δ
...id/profiling/internal/perfetto/PerfettoProfiler.kt 91.94% <100.00%> (+1.94%) ⬆️
...ernal/domain/scope/RumVitalAppLaunchEventHelper.kt 88.66% <100.00%> (+0.24%) ⬆️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 88.22% <100.00%> (+0.06%) ⬆️
.../internal/startup/RumSessionScopeStartupManager.kt 87.23% <100.00%> (+0.72%) ⬆️
...dog/android/profiling/internal/ProfilingFeature.kt 80.00% <50.00%> (-1.82%) ⬇️

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@datadog-official

datadog-official Bot commented Nov 21, 2025

Copy link
Copy Markdown

🎯 Code Coverage
Patch Coverage: 89.47%
Total Coverage: 71.40% (+0.03%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6fbff03 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@0xnm
0xnm force-pushed the yl/profiling/add-profiling-vital branch 2 times, most recently from dc5307e to 5ed9fb0 Compare November 21, 2025 14:47
@ambushwork
ambushwork force-pushed the yl/profiling/add-profiling-vital branch from 5ed9fb0 to 3db174e Compare November 24, 2025 12:13
@ambushwork
ambushwork marked this pull request as ready for review November 24, 2025 14:46
@ambushwork
ambushwork requested review from a team as code owners November 24, 2025 14:46
0xnm
0xnm previously approved these changes Nov 24, 2025
@ambushwork
ambushwork dismissed stale reviews from aleksandr-gringauz and 0xnm via 6fbff03 November 24, 2025 15:55
@ambushwork
ambushwork force-pushed the yl/profiling/add-profiling-vital branch from 3db174e to 6fbff03 Compare November 24, 2025 15:55
@ambushwork
ambushwork merged commit f8c30e2 into feature/perfetto-profiling Nov 24, 2025
27 checks passed
@ambushwork
ambushwork deleted the yl/profiling/add-profiling-vital branch November 24, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants