[RUM-12638][Cronet]: Cronet integration module and sample app support#2999
Merged
satween merged 4 commits intoNov 13, 2025
Merged
Conversation
satween
changed the title
satween
force-pushed
the
tvaleev/feature/RUM-12638-module-for-cronet
branch
from
November 11, 2025 00:22
ad9ca1e to
e10ec66
Compare
|
🎯 Code Coverage 🔗 Commit SHA: 600a0a4 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/cronet #2999 +/- ##
==================================================
- Coverage 71.40% 71.11% -0.29%
==================================================
Files 859 859
Lines 31308 31308
Branches 5275 5275
==================================================
- Hits 22355 22263 -92
- Misses 7493 7545 +52
- Partials 1460 1500 +40 🚀 New features to boost your workflow:
|
0xnm
reviewed
Nov 12, 2025
| // Build | ||
| id("com.android.library") | ||
| kotlin("android") | ||
| id("com.google.devtools.ksp") |
Member
There was a problem hiding this comment.
minor: let's remove this and add it only when needed
Contributor
Author
There was a problem hiding this comment.
well, this is needed for Noop generation, removed for now
ambushwork
reviewed
Nov 12, 2025
ambushwork
approved these changes
Nov 13, 2025
0xnm
reviewed
Nov 13, 2025
| } | ||
|
|
||
| dependencies { | ||
| api(libs.cronetApi) |
Member
There was a problem hiding this comment.
this should be implementation I think, not api.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds new gradle module for Cronet integration.
Adds new page to manually check Cronet integration into the Sample application.
Review checklist (to be filled by reviewers)