[flags] feat: scaffold openfeature provider module by typotter · Pull Request #2996 · DataDog/dd-sdk-android

typotter · 2025-11-10T06:44:18Z

What does this PR do?

Scaffolds new Flags Openfeature provider module

Motivation

The incompleteness and instability of the Kotline Openfeature SDK led us to develop the dd-sdk-android-flags client api. Until the Openfeature SDK is stable, we want to include it by way of a feature module.

Additional Notes

Anything else we should know when reviewing?
This scaffold is based on the flags module

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Make sure you discussed the feature or bugfix with the maintaining team in an Issue
Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

datadog-official · 2025-11-10T07:51:39Z

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 71.29% (+0.03%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 2e65f37 | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

codecov-commenter · 2025-11-10T08:01:22Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.31%. Comparing base (ac6a9f5) to head (2e65f37).
⚠️ Report is 556 commits behind head on feature/flags-ofeat.

Additional details and impacted files

@@                   Coverage Diff                   @@
##           feature/flags-ofeat    #2996      +/-   ##
=======================================================
- Coverage                71.40%   71.31%   -0.10%     
=======================================================
  Files                      859      860       +1     
  Lines                    31308    31316       +8     
  Branches                  5275     5275              
=======================================================
- Hits                     22355    22330      -25     
- Misses                    7493     7516      +23     
- Partials                  1460     1470      +10

Files with missing lines	Coverage Δ
.../android/flags/openfeature/DatadogFlagsProvider.kt	`100.00% <100.00%> (ø)`

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

0xnm · 2025-11-10T08:29:06Z

+    implementation(project(":dd-sdk-android-internal"))
+
+    // OpenFeature SDK
+    api("dev.openfeature:kotlin-sdk:0.6.2")


we need to move this lib declaration to libs.versions.toml

0xnm · 2025-11-10T08:30:23Z

+    // Build
+    id("com.android.library")
+    kotlin("android")
+    id("com.google.devtools.ksp")


are we going to generate anything in this module based on @NoOpImplementation annotation?

0xnm · 2025-11-10T08:31:33Z

+    testImplementation(testFixtures(project(":dd-sdk-android-core")))
+    testImplementation(testFixtures(project(":features:dd-sdk-android-rum")))


we can add these later if needed, not necessarily they will be needed

typotter

Thanks Nikita. ptal

typotter · 2025-11-10T15:43:07Z

+    // Build
+    id("com.android.library")
+    kotlin("android")
+    id("com.google.devtools.ksp")


typotter · 2025-11-10T15:43:16Z

+    implementation(project(":dd-sdk-android-internal"))
+
+    // OpenFeature SDK
+    api("dev.openfeature:kotlin-sdk:0.6.2")


typotter · 2025-11-10T15:44:25Z

+    testImplementation(testFixtures(project(":dd-sdk-android-core")))
+    testImplementation(testFixtures(project(":features:dd-sdk-android-rum")))


0xnm · 2025-11-10T15:47:43Z

+    // Generate NoOp implementations
+    ksp(project(":tools:noopfactory"))


this needs also to be removed, because there is no KSP plugin, so no ksp configuration type.

typotter · 2025-11-10T16:21:38Z

/merge

dd-devflow-routing-codex · 2025-11-10T16:21:42Z

View all feedbacks in Devflow UI.

2025-11-10 16:21:42 UTC ℹ️ Start processing command /merge

2025-11-10 16:21:48 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-11-10 17:17:37 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in feature/flags-ofeat is approximately 0s (p90).

2025-11-10 18:06:09 UTC ℹ️ MergeQueue: This merge request was merged

0xnm · 2025-11-10T16:48:43Z

We will also need to add a job to publish this module and add it as a dependency for notify:merge-verification-metadata job (and update local_ci.sh), but let's do it another PR then.

typotter added 2 commits November 9, 2025 23:39

scaffold openfeature provider module

06861c0

detekt

63e7d16

typotter marked this pull request as ready for review November 10, 2025 07:03

typotter requested review from a team as code owners November 10, 2025 07:03

typotter changed the title ~~scaffold openfeature provider module~~ [flags] feat: scaffold openfeature provider module Nov 10, 2025

Add Openfeature license to 3p csv

ab5cc13

0xnm reviewed Nov 10, 2025

View reviewed changes

clean up build file

8ac11b4

typotter commented Nov 10, 2025

View reviewed changes

typotter requested a review from 0xnm November 10, 2025 15:45

0xnm previously approved these changes Nov 10, 2025

View reviewed changes

remove ksp from deps

2e65f37

typotter dismissed 0xnm’s stale review via 2e65f37 November 10, 2025 16:21

typotter requested a review from 0xnm November 10, 2025 16:21

dd-devflow Bot added the mergequeue-status: waiting label Nov 10, 2025

0xnm approved these changes Nov 10, 2025

View reviewed changes

dd-devflow Bot added mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: waiting mergequeue-status: queued labels Nov 10, 2025

dd-mergequeue Bot merged commit 6c2f8ab into feature/flags-ofeat Nov 10, 2025
27 of 29 checks passed

dd-devflow Bot removed the mergequeue-status: in_progress label Nov 10, 2025

dd-mergequeue Bot deleted the typo/flags-of-module branch November 10, 2025 18:06

dd-devflow Bot added the mergequeue-status: done label Nov 10, 2025

ncreated restored the typo/flags-of-module branch April 9, 2026 10:19

0xnm deleted the typo/flags-of-module branch April 24, 2026 09:43

		testImplementation(testFixtures(project(":dd-sdk-android-core")))
		testImplementation(testFixtures(project(":features:dd-sdk-android-rum")))

		// Generate NoOp implementations
		ksp(project(":tools:noopfactory"))

Uh oh!

Conversation

typotter commented Nov 10, 2025

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

Uh oh!

datadog-official Bot commented Nov 10, 2025 • edited by datadog-datadog-prod-us1 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

typotter left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

typotter commented Nov 10, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

datadog-official Bot commented Nov 10, 2025 •

edited by datadog-datadog-prod-us1 Bot

Loading

codecov-commenter commented Nov 10, 2025 •

edited

Loading

dd-devflow-routing-codex Bot commented Nov 10, 2025 •

edited

Loading