Skip to content

fix: Detekt violations in the flags module#2994

Merged
dd-mergequeue[bot] merged 6 commits into
developfrom
typo/detekt-errors
Nov 10, 2025
Merged

fix: Detekt violations in the flags module#2994
dd-mergequeue[bot] merged 6 commits into
developfrom
typo/detekt-errors

Conversation

@typotter

@typotter typotter commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Nov 7, 2025 •
edited
Loading

Copy link
Copy Markdown

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 71.13% (-0.13%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 429ad4b | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter

codecov-commenter commented Nov 7, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.10%. Comparing base (ac6a9f5) to head (429ad4b).

Files with missing lines Patch % Lines
...tadog/android/flags/internal/FlagValueConverter.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2994      +/-   ##
===========================================
- Coverage    71.37%   71.10%   -0.26%     
===========================================
  Files          859      859              
  Lines        31308    31309       +1     
  Branches      5275     5275              
===========================================
- Hits         22344    22262      -82     
- Misses        7499     7545      +46     
- Partials      1465     1502      +37
Files with missing lines Coverage Δ
...com/datadog/android/flags/internal/FlagsFeature.kt 83.08% <ø> (ø)
...s/internal/net/PrecomputedAssignmentsDownloader.kt 100.00% <ø> (ø)
...ternal/net/PrecomputedAssignmentsRequestFactory.kt 70.91% <ø> (ø)
...lags/internal/repository/DefaultFlagsRepository.kt 65.31% <ø> (ø)
...tadog/android/flags/internal/FlagValueConverter.kt 67.74% <50.00%> (+1.08%) ⬆️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@typotter
typotter marked this pull request as ready for review November 10, 2025 06:13
@typotter
typotter requested review from a team as code owners November 10, 2025 06:13
@typotter

typotter commented Nov 10, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Nov 10, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-11-10 06:35:08 UTC ℹ️ Start processing command /merge

2025-11-10 06:35:14 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-11-10 08:18:10 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in develop is approximately 1h (p90).

2025-11-10 08:32:27 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit 65f50a7:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@typotter typotter changed the title add flags custom detekt rules fix: Detekt violations in the flags module Nov 10, 2025
0xnm
0xnm previously approved these changes Nov 10, 2025
View reviewed changes
Comment thread detekt_custom_safe_calls.yml
@typotter

typotter commented Nov 10, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Nov 10, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-11-10 15:47:17 UTC ℹ️ Start processing command /merge

2025-11-10 15:47:22 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in develop is approximately 1h (p90).

2025-11-10 16:17:01 UTC ❌ MergeQueue: This merge request was updated

This PR is rejected because it was updated

@typotter
typotter requested a review from 0xnm November 10, 2025 16:17
@typotter

typotter commented Nov 10, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Nov 10, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-11-10 16:17:14 UTC ℹ️ Start processing command /merge

2025-11-10 16:17:19 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-11-10 17:03:28 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in develop is approximately 1h (p90).

2025-11-10 17:26:06 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit f419346:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@typotter

typotter commented Nov 10, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Nov 10, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-11-10 17:46:46 UTC ℹ️ Start processing command /merge

2025-11-10 17:46:51 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in develop is approximately 1h (p90).

2025-11-10 18:36:34 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit d3c4acb into develop Nov 10, 2025
28 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the typo/detekt-errors branch November 10, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@typotter @codecov-commenter @0xnm