Add missing Profile event tags#2992
Merged
0xnm merged 1 commit intoNov 10, 2025
Merged
Conversation
Base automatically changed from
nogorodnikov/merge-develop-into-perfetto-profiling
to
feature/perfetto-profiling
November 7, 2025 16:23
|
🎯 Code Coverage 🔗 Commit SHA: 082b612 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
satween
approved these changes
Nov 7, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/perfetto-profiling #2992 +/- ##
==============================================================
+ Coverage 71.14% 71.26% +0.12%
==============================================================
Files 872 872
Lines 31549 31554 +5
Branches 5298 5298
==============================================================
+ Hits 22443 22485 +42
+ Misses 7602 7577 -25
+ Partials 1504 1492 -12
🚀 New features to boost your workflow:
|
aleksandr-gringauz
approved these changes
Nov 10, 2025
ambushwork
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds missing tags to the
ProfileEvent:env,runtime,sdk_versionso that core facets are now correctly filled.This brings us closer to the set of tags iOS is sending https://github.com/DataDog/dd-sdk-ios/blob/c5c677957cc03d939232674b1689597915fb02e1/DatadogProfiling/Sources/AppLaunchProfiler.swift#L50-L66.
Review checklist (to be filled by reviewers)