Skip to content

RUM-13103: Introduce vitalAppLaunchEventMapper#2987

Merged
ambushwork merged 2 commits into
developfrom
aleksandr-gringauz/feature/app-launch-vitals-mapper
Dec 23, 2025
Merged

RUM-13103: Introduce vitalAppLaunchEventMapper#2987
ambushwork merged 2 commits into
developfrom
aleksandr-gringauz/feature/app-launch-vitals-mapper

Conversation

@aleksandr-gringauz

@aleksandr-gringauz aleksandr-gringauz commented Nov 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Adding vitalAppLaunchEventMapper similar to vitalOperationStepEventMapper now that app launch vital events have a separate type.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@datadog-official

datadog-official Bot commented Nov 5, 2025 •
edited by datadog-datadog-prod-us1 Bot
Loading

Copy link
Copy Markdown

🎯 Code Coverage
• Patch Coverage: 68.42%
• Overall Coverage: 66.37% (+0.02%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9924563 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter

codecov-commenter commented Nov 5, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.36%. Comparing base (aac24ca) to head (9924563).
⚠️ Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...kotlin/com/datadog/android/rum/RumConfiguration.kt 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2987      +/-   ##
===========================================
+ Coverage    71.30%   71.36%   +0.05%     
===========================================
  Files          880      880              
  Lines        32360    32368       +8     
  Branches      5457     5457              
===========================================
+ Hits         23074    23097      +23     
+ Misses        7736     7732       -4     
+ Partials      1550     1539      -11
Files with missing lines Coverage Δ
...lin/com/datadog/android/rum/internal/RumFeature.kt 89.47% <100.00%> (-0.16%) ⬇️
...ndroid/rum/internal/domain/event/RumEventMapper.kt 100.00% <100.00%> (+1.67%) ⬆️
...kotlin/com/datadog/android/rum/RumConfiguration.kt 94.25% <83.33%> (+0.28%) ⬆️

... and 49 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aleksandr-gringauz
aleksandr-gringauz marked this pull request as ready for review November 6, 2025 11:04
@aleksandr-gringauz
aleksandr-gringauz requested review from a team as code owners November 6, 2025 11:04
0xnm
0xnm reviewed Nov 6, 2025
View reviewed changes
Comment thread features/dd-sdk-android-rum/api/apiSurface Outdated
@aleksandr-gringauz
aleksandr-gringauz force-pushed the aleksandr-gringauz/feature/app-launch-vitals-mapper branch from 84212fe to 58ca36d Compare November 6, 2025 16:12
ambushwork
ambushwork previously approved these changes Nov 7, 2025
View reviewed changes
jonathanmos
jonathanmos previously approved these changes Nov 12, 2025
View reviewed changes
@aleksandr-gringauz
aleksandr-gringauz force-pushed the aleksandr-gringauz/feature/app-launch-vitals branch 2 times, most recently from 1c884cb to 39cc533 Compare November 14, 2025 10:08
@aleksandr-gringauz aleksandr-gringauz changed the title Introduce vitalAppLaunchEventMapper RUM-13103: Introduce vitalAppLaunchEventMapper Nov 28, 2025
@0xnm 0xnm mentioned this pull request Dec 17, 2025
Merged
3 tasks
Base automatically changed from aleksandr-gringauz/feature/app-launch-vitals to develop December 18, 2025 15:58
@ambushwork
ambushwork dismissed stale reviews from jonathanmos and themself December 18, 2025 15:58

The base branch was changed.

@ambushwork
ambushwork force-pushed the aleksandr-gringauz/feature/app-launch-vitals-mapper branch from 58ca36d to deb5025 Compare December 23, 2025 10:06
@ambushwork
ambushwork force-pushed the aleksandr-gringauz/feature/app-launch-vitals-mapper branch from bf1be14 to 9924563 Compare December 23, 2025 11:16
@aleksandr-gringauz

aleksandr-gringauz commented Dec 23, 2025

Copy link
Copy Markdown
Contributor Author

LGTM

@ambushwork
ambushwork merged commit 4f0f65a into develop Dec 23, 2025
26 checks passed
@ambushwork
ambushwork deleted the aleksandr-gringauz/feature/app-launch-vitals-mapper branch December 23, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@satween satween satween left review comments
@0xnm 0xnm 0xnm approved these changes
@ambushwork ambushwork ambushwork left review comments
@jonathanmos jonathanmos jonathanmos left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aleksandr-gringauz @codecov-commenter @satween @0xnm @ambushwork @jonathanmos