Skip to content

Remove unused isConstantClass variable#2984

Merged
dd-mergequeue[bot] merged 1 commit into
developfrom
aleksandr-gringauz/remove-unused-isconstantclass
Nov 5, 2025
Merged

Remove unused isConstantClass variable#2984
dd-mergequeue[bot] merged 1 commit into
developfrom
aleksandr-gringauz/remove-unused-isconstantclass

Conversation

@aleksandr-gringauz

@aleksandr-gringauz aleksandr-gringauz commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Just removing unused code that resulted in warnings during build:

> Task :buildSrc:compileKotlin
w: file:///Users/aleksandr.gringauz/projects/dd-sdk-android-2/buildSrc/src/main/kotlin/com/datadog/gradle/plugin/jsonschema/generator/ClassStringDeserializerGenerator.kt:24:13 Variable 'isConstantClass' is never used

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Nov 5, 2025 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 70.92% (+0.05%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8b17e4e | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter

codecov-commenter commented Nov 5, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.86%. Comparing base (4e9b85d) to head (8b17e4e).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2984      +/-   ##
===========================================
- Coverage    70.88%   70.86%   -0.02%     
===========================================
  Files          829      829              
  Lines        30384    30384              
  Branches      5186     5186              
===========================================
- Hits         21535    21529       -6     
- Misses        7372     7379       +7     
+ Partials      1477     1476       -1

see 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aleksandr-gringauz
aleksandr-gringauz marked this pull request as ready for review November 5, 2025 10:36
@aleksandr-gringauz
aleksandr-gringauz requested review from a team as code owners November 5, 2025 10:36
@aleksandr-gringauz

aleksandr-gringauz commented Nov 5, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Nov 5, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-11-05 10:44:09 UTC ℹ️ Start processing command /merge

2025-11-05 10:44:15 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-11-05 10:54:19 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in develop is approximately 0s (p90).

2025-11-05 11:45:10 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit aa4a68f into develop Nov 5, 2025
28 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the aleksandr-gringauz/remove-unused-isconstantclass branch November 5, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambushwork ambushwork ambushwork approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aleksandr-gringauz @codecov-commenter @ambushwork