Skip to content

feat: allow blank targeting keys#2981

Merged
dd-mergequeue[bot] merged 3 commits into
feature/feature-flaggingfrom
typo/blank-targeting-key
Nov 4, 2025
Merged

feat: allow blank targeting keys#2981
dd-mergequeue[bot] merged 3 commits into
feature/feature-flaggingfrom
typo/blank-targeting-key

Conversation

@typotter

@typotter typotter commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Remove restriction on blank/whitespace-only targeting keys

Motivation

A blank targeting key is valid and supported.

Additional Notes

While a blank targeting key is discouraged, it does not present technical problems. Customers are coached on proper use of targeting key

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@typotter
typotter marked this pull request as ready for review November 4, 2025 16:23
@typotter
typotter requested review from a team as code owners November 4, 2025 16:23
0xnm
0xnm previously approved these changes Nov 4, 2025
View reviewed changes
Comment thread features/dd-sdk-android-flags/README.md Outdated
@typotter @0xnm
ref SharedPreferences
fa30ccd 
Co-authored-by: Nikita Ogorodnikov <[email protected]>
@typotter

typotter commented Nov 4, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Nov 4, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-11-04 16:41:24 UTC ℹ️ Start processing command /merge

2025-11-04 16:41:30 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-11-04 17:29:29 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in feature/feature-flagging is approximately 1h (p90).

2025-11-04 18:23:18 UTC ℹ️ MergeQueue: This merge request was merged

@typotter
typotter requested a review from 0xnm November 4, 2025 16:41
@codecov-commenter

codecov-commenter commented Nov 4, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.24%. Comparing base (2ff5bc0) to head (fa30ccd).
⚠️ Report is 4 commits behind head on feature/feature-flagging.

Additional details and impacted files 
@@                     Coverage Diff                      @@
##           feature/feature-flagging    #2981      +/-   ##
============================================================
+ Coverage                     71.16%   71.24%   +0.08%     
============================================================
  Files                           859      859              
  Lines                         31320    31320              
  Branches                       5283     5282       -1     
============================================================
+ Hits                          22287    22311      +24     
+ Misses                         7542     7537       -5     
+ Partials                       1491     1472      -19
Files with missing lines Coverage Δ
...tadog/android/flags/internal/DatadogFlagsClient.kt 90.51% <ø> (-1.04%) ⬇️
...m/datadog/android/flags/model/EvaluationContext.kt 100.00% <ø> (ø)

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Nov 4, 2025 •
edited
Loading

Copy link
Copy Markdown

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 71.21% (-0.03%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: fa30ccd | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@dd-mergequeue
dd-mergequeue Bot merged commit dfe0334 into feature/feature-flagging Nov 4, 2025
27 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the typo/blank-targeting-key branch November 4, 2025 18:23
@ncreated
ncreated restored the typo/blank-targeting-key branch April 9, 2026 10:19
@0xnm
0xnm deleted the typo/blank-targeting-key branch April 24, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@typotter @codecov-commenter @0xnm