RUM-11897: Add scripts to set/get Vault secrets & Migrate CI#2974
Merged
Conversation
ambushwork
force-pushed
the
yl/add-vaults-secrets-defs
branch
7 times, most recently
from
November 3, 2025 20:32
5e9a81e to
5bde49e
Compare
|
🎯 Code Coverage 🔗 Commit SHA: ffe66af | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2974 +/- ##
===========================================
- Coverage 71.22% 71.20% -0.02%
===========================================
Files 876 876
Lines 32118 32118
Branches 5429 5429
===========================================
- Hits 22874 22869 -5
- Misses 7699 7705 +6
+ Partials 1545 1544 -1 🚀 New features to boost your workflow:
|
ambushwork
force-pushed
the
yl/add-vaults-secrets-defs
branch
17 times, most recently
from
November 10, 2025 15:03
c83a82e to
b166c1b
Compare
ambushwork
force-pushed
the
yl/add-vaults-secrets-defs
branch
3 times, most recently
from
November 18, 2025 09:41
bc86c66 to
85c6bfd
Compare
ambushwork
changed the title
ambushwork
marked this pull request as ready for review
November 18, 2025 09:42
0xnm
reviewed
Nov 18, 2025
ambushwork
force-pushed
the
yl/add-vaults-secrets-defs
branch
from
December 18, 2025 16:53
85c6bfd to
c5bbb97
Compare
Member
Author
|
Updated the PR, main changes:
|
0xnm
reviewed
Dec 18, 2025
ambushwork
force-pushed
the
yl/add-vaults-secrets-defs
branch
from
December 18, 2025 17:34
c5bbb97 to
ffe66af
Compare
0xnm
approved these changes
Dec 18, 2025
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
🚀
probably worth having another pair of eyes, since it is security-related
aleksandr-gringauz
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)