Skip to content

RUM-12061: Add tests to core RUM Debug Widget components#2971

Merged
kikoveiga merged 12 commits into
tvaleev/feature/innovation-week-07-04-25from
kikoveiga/RUM-12061/add-tests
Nov 3, 2025
Merged

RUM-12061: Add tests to core RUM Debug Widget components#2971
kikoveiga merged 12 commits into
tvaleev/feature/innovation-week-07-04-25from
kikoveiga/RUM-12061/add-tests

Conversation

@kikoveiga

@kikoveiga kikoveiga commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Add unit and integration tests for DefaultInsightsCollector.
  • Other unit tests for small extension functions.

Motivation

  • Ensure the new widget is well implemented and integrated in the SDK.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@kikoveiga kikoveiga self-assigned this Oct 29, 2025
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Oct 29, 2025

Copy link
Copy Markdown

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 70.20%

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4e1231c | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter

codecov-commenter commented Oct 29, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 52.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.40%. Comparing base (429cca6) to head (4e1231c).

Files with missing lines Patch % Lines
...tadog/android/insights/DefaultInsightsCollector.kt 63.16% 7 Missing ⚠️
...dog/android/insights/internal/platform/Platform.kt 0.00% 4 Missing ⚠️
...og/android/insights/internal/extensions/LangExt.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                             Coverage Diff                              @@
##           tvaleev/feature/innovation-week-07-04-25    #2971      +/-   ##
============================================================================
+ Coverage                                     70.02%   70.40%   +0.38%     
============================================================================
  Files                                           839      840       +1     
  Lines                                         30766    30780      +14     
  Branches                                       5232     5233       +1     
============================================================================
+ Hits                                          21543    21670     +127     
+ Misses                                         7745     7655      -90     
+ Partials                                       1478     1455      -23     
Files with missing lines Coverage Δ
.../android/rum/internal/domain/scope/RumViewScope.kt 94.06% <100.00%> (+0.29%) ⬆️
...rnal/instrumentation/insights/InsightsCollector.kt 0.00% <ø> (ø)
...og/android/insights/internal/extensions/LangExt.kt 27.78% <0.00%> (+27.78%) ⬆️
...dog/android/insights/internal/platform/Platform.kt 0.00% <0.00%> (ø)
...tadog/android/insights/DefaultInsightsCollector.kt 76.71% <63.16%> (+76.71%) ⬆️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kikoveiga
kikoveiga requested a review from satween October 30, 2025 13:28
@kikoveiga
kikoveiga marked this pull request as ready for review October 30, 2025 13:28
@kikoveiga
kikoveiga requested review from a team as code owners October 30, 2025 13:28
Base automatically changed from kikoveiga/RUM-12060/move-widget-code to tvaleev/feature/innovation-week-07-04-25 November 3, 2025 09:36
@kikoveiga
kikoveiga merged commit 97368ae into tvaleev/feature/innovation-week-07-04-25 Nov 3, 2025
25 checks passed
@kikoveiga
kikoveiga deleted the kikoveiga/RUM-12061/add-tests branch November 3, 2025 09:44
@ncreated
ncreated restored the kikoveiga/RUM-12061/add-tests branch April 9, 2026 10:20
@0xnm
0xnm deleted the kikoveiga/RUM-12061/add-tests branch April 24, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants