Skip to content

Rename ProfilingEvent to ProfileEvent#2969

Merged
0xnm merged 1 commit into
feature/perfetto-profilingfrom
nogorodnikov/rename-profilingevent-profile-event
Oct 27, 2025
Merged

Rename ProfilingEvent to ProfileEvent#2969
0xnm merged 1 commit into
feature/perfetto-profilingfrom
nogorodnikov/rename-profilingevent-profile-event

Conversation

@0xnm

@0xnm 0xnm commented Oct 27, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Tiny alignment with Browser SDK https://github.com/DataDog/browser-sdk/blob/daeb30f323c58a42e820ed17177186f5e304b984/packages/rum/src/domain/profiling/transport/assembly.ts#L7.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners October 27, 2025 14:08
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Oct 27, 2025

Copy link
Copy Markdown

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 70.93% (+0.02%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4639638 | Docs | Was this helpful? Give us feedback!

@codecov-commenter

codecov-commenter commented Oct 27, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.88%. Comparing base (5184a9f) to head (4639638).
⚠️ Report is 916 commits behind head on feature/perfetto-profiling.

Additional details and impacted files
@@                      Coverage Diff                       @@
##           feature/perfetto-profiling    #2969      +/-   ##
==============================================================
+ Coverage                       70.83%   70.88%   +0.04%     
==============================================================
  Files                             842      842              
  Lines                           30622    30622              
  Branches                         5206     5206              
==============================================================
+ Hits                            21691    21704      +13     
+ Misses                           7449     7430      -19     
- Partials                         1482     1488       +6     
Files with missing lines Coverage Δ
.../android/profiling/internal/ProfilingDataWriter.kt 97.14% <100.00%> (ø)

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm merged commit 558eba1 into feature/perfetto-profiling Oct 27, 2025
27 checks passed
@0xnm
0xnm deleted the nogorodnikov/rename-profilingevent-profile-event branch October 27, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants