Skip to content

[flags] chore: remove redundant featureflags subpackage#2966

Merged
typotter merged 5 commits into
feature/feature-flaggingfrom
typo/FFL-1109-remove-featureflags-subpackage
Oct 24, 2025
Merged

[flags] chore: remove redundant featureflags subpackage#2966
typotter merged 5 commits into
feature/feature-flaggingfrom
typo/FFL-1109-remove-featureflags-subpackage

Conversation

@typotter

@typotter typotter commented Oct 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR moves the contents of the featureflags package up one level, thus removing a redundant package layer

Also ran ktlint.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@typotter
typotter changed the base branch from develop to feature/feature-flagging October 23, 2025 22:27
@typotter typotter changed the title Typo/ffl 1109 remove featureflags subpackage [flags] chore: remove redundant featureflags subpackage Oct 24, 2025
@codecov-commenter

codecov-commenter commented Oct 24, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.88%. Comparing base (d1a3f4d) to head (012c85c).
⚠️ Report is 157 commits behind head on feature/feature-flagging.

Additional details and impacted files 
@@                     Coverage Diff                      @@
##           feature/feature-flagging    #2966      +/-   ##
============================================================
+ Coverage                     70.83%   70.88%   +0.04%     
============================================================
  Files                           841      840       -1     
  Lines                         30574    30547      -27     
  Branches                       5167     5167              
============================================================
- Hits                          21657    21651       -6     
+ Misses                         7451     7441      -10     
+ Partials                       1466     1455      -11
Files with missing lines Coverage Δ
...in/kotlin/com/datadog/android/flags/FlagsClient.kt 35.58% <ø> (ø)
...tadog/android/flags/internal/DatadogFlagsClient.kt 89.55% <ø> (ø)
.../android/flags/internal/ExposureEventsProcessor.kt 100.00% <ø> (ø)
...tadog/android/flags/internal/FlagValueConverter.kt 66.67% <ø> (ø)
...com/datadog/android/flags/internal/FlagsFeature.kt 88.37% <ø> (ø)
.../datadog/android/flags/internal/NoOpFlagsClient.kt 76.19% <ø> (ø)
...adog/android/flags/internal/RumEvaluationLogger.kt 100.00% <ø> (ø)
...id/flags/internal/evaluation/EvaluationsManager.kt 89.29% <ø> (ø)
...tadog/android/flags/internal/model/FlagsContext.kt 100.00% <ø> (ø)
...og/android/flags/internal/model/FlagsStateEntry.kt 100.00% <ø> (ø)
... and 10 more

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@typotter
typotter marked this pull request as ready for review October 24, 2025 04:30
@typotter
typotter requested review from a team as code owners October 24, 2025 04:30
@typotter
typotter merged commit 38bd253 into feature/feature-flagging Oct 24, 2025
25 checks passed
@typotter
typotter deleted the typo/FFL-1109-remove-featureflags-subpackage branch October 24, 2025 07:13
@typotter typotter mentioned this pull request Oct 27, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@typotter @codecov-commenter @0xnm