Skip to content

Add file size in profiling telemetry & fix unit test#2964

Merged
ambushwork merged 1 commit into
feature/perfetto-profilingfrom
yl/profiling-update-telemetry
Oct 23, 2025
Merged

Add file size in profiling telemetry & fix unit test#2964
ambushwork merged 1 commit into
feature/perfetto-profilingfrom
yl/profiling-update-telemetry

Conversation

@ambushwork

Copy link
Copy Markdown
Member

What does this PR do?

Add file zie in profiling telemetry:
image

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@ambushwork
ambushwork force-pushed the yl/profiling-update-telemetry branch 2 times, most recently from ff46e11 to 8eef978 Compare October 23, 2025 09:50
@ambushwork
ambushwork marked this pull request as ready for review October 23, 2025 10:14
@ambushwork
ambushwork requested review from a team as code owners October 23, 2025 10:14
@datadog-official

datadog-official Bot commented Oct 23, 2025

Copy link
Copy Markdown

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 70.91% (+0.02%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: eed7d39 | Docs | Was this helpful? Give us feedback!

0xnm
0xnm previously approved these changes Oct 23, 2025
jonathanmos
jonathanmos previously approved these changes Oct 23, 2025
@ambushwork
ambushwork dismissed stale reviews from jonathanmos and 0xnm via 26c5ea0 October 23, 2025 11:52
@ambushwork
ambushwork force-pushed the yl/profiling-update-telemetry branch from 8eef978 to 26c5ea0 Compare October 23, 2025 11:52
0xnm
0xnm previously approved these changes Oct 23, 2025
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.79%. Comparing base (46d5192) to head (eed7d39).

Files with missing lines Patch % Lines
...id/profiling/internal/perfetto/PerfettoProfiler.kt 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##           feature/perfetto-profiling    #2964      +/-   ##
==============================================================
- Coverage                       70.84%   70.79%   -0.05%     
==============================================================
  Files                             842      842              
  Lines                           30616    30622       +6     
  Branches                         5204     5206       +2     
==============================================================
- Hits                            21687    21676      -11     
- Misses                           7457     7468      +11     
- Partials                         1472     1478       +6     
Files with missing lines Coverage Δ
.../android/core/internal/persistence/file/FileExt.kt 83.33% <ø> (ø)
...id/profiling/internal/perfetto/PerfettoProfiler.kt 90.00% <85.71%> (-0.74%) ⬇️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ambushwork
ambushwork merged commit 5184a9f into feature/perfetto-profiling Oct 23, 2025
26 checks passed
@ambushwork
ambushwork deleted the yl/profiling-update-telemetry branch October 23, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants