RUM-12046: Pass synthetic ids to RUM earlier in benchmark app#2959
Merged
aleksandr-gringauz merged 1 commit intoOct 22, 2025
Conversation
aleksandr-gringauz
force-pushed
the
aleksandr-gringauz/RUM-12046/fix-synthetics-rum-association-in-benchmark-app
branch
2 times, most recently
from
October 22, 2025 07:36
ce34ad5 to
d2fbbf5
Compare
|
🎯 Code Coverage 🔗 Commit SHA: 63b103b | Docs | Was this helpful? Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Please upload reports for the commit 63b103b to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## develop #2959 +/- ##
===========================================
+ Coverage 70.79% 70.89% +0.09%
===========================================
Files 829 829
Lines 30384 30384
Branches 5184 5184
===========================================
+ Hits 21510 21538 +28
+ Misses 7392 7372 -20
+ Partials 1482 1474 -8
🚀 New features to boost your workflow:
|
aleksandr-gringauz
force-pushed
the
aleksandr-gringauz/RUM-12046/fix-synthetics-rum-association-in-benchmark-app
branch
from
October 22, 2025 13:37
d2fbbf5 to
63b103b
Compare
aleksandr-gringauz
marked this pull request as ready for review
October 22, 2025 15:12
0xnm
approved these changes
Oct 22, 2025
aleksandr-gringauz
deleted the
aleksandr-gringauz/RUM-12046/fix-synthetics-rum-association-in-benchmark-app
branch
October 22, 2025 15:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Right now RUM sessions that correspond to synthetic test runs of the benchmark app don't contain the information about the synthetic test.
The reason is that this code is called on the
Activitywhoseintentdoesn't have the necessary ids.This in turn happens because in the benchmark app we first open LaunchActivity to determine what features of the SDK we want to enable and what test scenario to run. And only after that we launch a scenario-specific
Activity. ThusintentforLaunchActivitycontains these ids.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)