RUM-12046: Fix synthetic ids logging in RumViewScope#2958
Merged
aleksandr-gringauz merged 1 commit intoOct 23, 2025
Merged
Conversation
aleksandr-gringauz
marked this pull request as ready for review
October 21, 2025 15:28
0xnm
previously approved these changes
Oct 21, 2025
|
🎯 Code Coverage 🔗 Commit SHA: cb5dcfa | Docs | Was this helpful? Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2958 +/- ##
===========================================
+ Coverage 70.81% 70.83% +0.02%
===========================================
Files 829 829
Lines 30384 30381 -3
Branches 5184 5184
===========================================
+ Hits 21516 21519 +3
+ Misses 7387 7377 -10
- Partials 1481 1485 +4
🚀 New features to boost your workflow:
|
| target = InternalLogger.Target.USER, | ||
| messageBuilder = { "$key=$value" } | ||
| ) | ||
| /** |
Contributor
Author
There was a problem hiding this comment.
Added a comment so that it is not removed by mistake again.
0xnm
approved these changes
Oct 21, 2025
jonathanmos
approved these changes
Oct 22, 2025
aleksandr-gringauz
force-pushed
the
aleksandr-gringauz/RUM-12046/fix-synthetics-rum-association
branch
from
October 22, 2025 15:14
a16370b to
82abefb
Compare
aleksandr-gringauz
force-pushed
the
aleksandr-gringauz/RUM-12046/fix-synthetics-rum-association
branch
from
October 22, 2025 15:47
82abefb to
cb5dcfa
Compare
aleksandr-gringauz
deleted the
aleksandr-gringauz/RUM-12046/fix-synthetics-rum-association
branch
October 23, 2025 08:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I'm returning
Log.ithat was changed here toInternalLoggerusage.See the detailed explanation of the bug and its cause in the ticket: https://datadoghq.atlassian.net/browse/RUM-12046
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)