[flags] FFL-1185 generate ExposureEvent from schema#2957
Merged
jonathanmos merged 1 commit intoOct 23, 2025
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/feature-flagging #2957 +/- ##
============================================================
- Coverage 70.87% 70.81% -0.06%
============================================================
Files 841 840 -1
Lines 30577 30550 -27
Branches 5168 5168
============================================================
- Hits 21670 21632 -38
- Misses 7447 7450 +3
- Partials 1460 1468 +8
🚀 New features to boost your workflow:
|
jonathanmos
marked this pull request as ready for review
October 21, 2025 14:52
aleksandr-gringauz
previously approved these changes
Oct 21, 2025
0xnm
approved these changes
Oct 22, 2025
jonathanmos
force-pushed
the
jmoskovich/ffl-1185/code-health
branch
from
October 22, 2025 08:07
f1f1116 to
68674d9
Compare
0xnm
previously approved these changes
Oct 22, 2025
Base automatically changed from
typo/FFL-1184-resolve-value-method
to
feature/feature-flagging
October 22, 2025 17:15
typotter
dismissed stale reviews from 0xnm and aleksandr-gringauz
October 22, 2025 17:15
The base branch was changed.
aleksandr-gringauz
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replace the hardcoded ExposureEvent with one generated from a json schema. This follows more closely our pattern for events.
To generate the ExposureEvent:
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)